search

mozilla / missioncontrol

Real-time monitoring of Firefox release health
Mozilla Public License 2.0
21 stars 18 forks source link

Pre-cache aggregated results from server using a celery job #108

Closed wlach closed 7 years ago

wlach commented 7 years ago

@maurodoglio I'm posting this work-in-progress here now in case you want to comment on it (note that I'm going to be out until next Wednesday), it's a pretty significant change from our current approach. Basically we query the presto store offline and store in redis, doing various transforms in line with the business logic for the application (throwing out old data, etc). The celery/API parts are pretty much working AFAICT, I just need to update the frontend to use it.

wlach commented 7 years ago

This is now ready for review, I think.

codecov-io commented 7 years ago

Codecov Report

Merging #108 into master will increase coverage by 16.01%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
+ Coverage   46.29%   62.31%   +16.01%     
===========================================
  Files          13       16        +3     
  Lines         270      329       +59     
  Branches       30       46       +16     
===========================================
+ Hits          125      205       +80     
+ Misses        143      114       -29     
- Partials        2       10        +8
Impacted Files Coverage Δ
missioncontrol/api/urls.py 100% <ø> (ø) :arrow_up:
missioncontrol/etl/tasks.py 0% <0%> (ø) :arrow_up:
missioncontrol/etl/versions.py 100% <100%> (ø)
missioncontrol/etl/schema.py 100% <100%> (ø)
missioncontrol/etl/presto.py 28% <50%> (ø)
missioncontrol/api/views.py 41.5% <52.63%> (+19.97%) :arrow_up:
missioncontrol/settings.py 94.2% <60%> (-2.73%) :arrow_down:
missioncontrol/etl/measure.py 79.06% <79.06%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35ef1d6...ab2b2c0. Read the comment docs.

wlach commented 7 years ago

Fixed/added a few things that I noticed while implementing more features on top of this PR.

wlach commented 7 years ago

Addressed most of the comments, a question about one of them.