`make tests` doesn't work

[wlach]

Running make tests from the commandline doesn't work (unless I add pytest to the requirements). @maurodoglio -- do you know what's going on?

Hammersmith:missioncontrol wlach$ make tests
docker-compose run web tox -etests
Starting missioncontrol_db_1 ... 
Starting missioncontrol_redis_1 ... done
Starting missioncontrol_hdfs-namenode_1 ... done
Starting missioncontrol_metastore_1 ... done
Starting missioncontrol_presto_1 ... done
GLOB sdist-make: /app/setup.py
tests inst-nodeps: /app/.tox/dist/missioncontrol-0.1dev.zip
tests installed: amqp==2.2.1,billiard==3.5.0.3,boto3==1.4.5,botocore==1.5.92,Brotli==0.6.0,celery==4.1.0,celery-redbeat==0.10.0,certifi==2017.7.27.1,chardet==3.0.4,colorama==0.3.2,configparser==3.5.0,cookies==2.2.1,coverage==4.4.1,dj-database-url==0.4.2,Django==1.11.4,django-cache-url==2.0.0,django-celery-monitor==1.1.2,django-celery-results==1.0.1,django-cors-headers==2.1.0,django-csp==3.3,django-redis==4.8.0,django-session-csrf==0.7.1,dockerflow==2017.5.0,docutils==0.14,enum34==1.1.6,flake8==3.4.1,freezegun==0.3.9,future==0.16.0,gunicorn==19.7.1,hashin==0.11.2,html5lib==0.999,idna==2.6,jmespath==0.9.3,kombu==4.1.0,MarkupSafe==1.0,mccabe==0.6.1,missioncontrol==0.1.dev0,monotonic==1.3,newrelic==2.90.0.75,pep8==1.7.0,pluggy==0.4.0,psycopg2==2.7.3,py==1.4.34,PyAthena==1.1.0,pycodestyle==2.3.1,pyflakes==1.6.0,PyHive==0.4.0,pytest-cov==2.5.1,python-dateutil==2.6.1,python-decouple==3.1,pytz==2017.2,redis==2.10.5,requests==2.18.3,responses==0.7.0,s3transfer==0.1.10,six==1.10.0,SQLAlchemy==1.1.13,tenacity==4.4.0,tox==2.7.0,urllib3==1.22,vine==1.1.4,virtualenv==15.1.0,whitenoise==3.3.0
tests runtests: PYTHONHASHSEED='2087835725'
tests runtests: commands[0] | pytest --cov=missioncontrol
ERROR: InvocationError: could not find executable 'pytest'
_________________________________________________________________________________ summary __________________________________________________________________________________
ERROR:   tests: commands failed
make: *** [tests] Error 1

[wlach]

Maybe a side effect of #117?

[wlach]

I have isolated this down to either us not running pipstrap anymore in tox (change in #117) or (less likely) us installing the coverage package at the wrong time.

If the former, the solution might just be to switch to a python 3.6 image (which presumably has a newer version of pip).

Will look at this tomorrow.

[wlach]

It's pipstrap. But upgrading python to 3.6 (which comes with pip 9.1) removes the need for that.

[wlach]

This has been fixed for a while.