search

mozilla / missioncontrol

Real-time monitoring of Firefox release health
Mozilla Public License 2.0
21 stars 18 forks source link

Add testing of some the frontend components (especially those formatting/displaying numbers) #317

Closed wlach closed 5 years ago

wlach commented 6 years ago

This week an embarassing bug slipped in where we were showing the incorrect summary rates in the main dashboard views. Our tests to validate data ingestion and server-side apis didn't succeed in catching this because this was entirely a frontend problem.

We should wire up some simple tests for some of the react components (e.g. the summary cards) with jest so this type of error is less likely to occur in the future.

kagehina919 commented 5 years ago

@wlach, could you please suggest some types of tests that should be written for the summary component to cover the number formattings?

wlach commented 5 years ago

@kagehina919 I think your work in #343 covers most of what I was hoping to do here.

It's a smaller thing, but if you have some spare cycles and feel like testing something simple I would take a look at #344. I should have some other things to look at soon too. :)