search

mozilla / missioncontrol

Real-time monitoring of Firefox release health
Mozilla Public License 2.0
21 stars 18 forks source link

Show data for at least 4 versions along with "other" #320

Closed wlach closed 6 years ago

wlach commented 6 years ago

Right now we only show data for 2 versions along with other in the detail view. We shouldn't clutter up the graph with 10+ series, but this is excessively low. E.g. here:

image

There's no reason we can't show all five visible series on this graph. It would be much more informative.

The coalescing happens around here:

https://github.com/mozilla/missioncontrol/blob/2e33078e75c096a63ca4c7cbb5854e1088ba3dee/frontend/ui/detailview.jsx#L284

Note the magic numbers of "2" and "3". I would define some constants (e.g. MAX_VISIBLE_SERIES) in this file:

https://github.com/mozilla/missioncontrol/blob/master/frontend/schema.js

And then import/use them in the file above.

wlach commented 6 years ago

@SJasoria this might be a fun one to work on, I promise this would be useful :)

SJasoria commented 6 years ago

I'll start working on this

mozillamarcia commented 6 years ago

Hello William - Did we make any progress on this one? Thanks.

SJasoria commented 6 years ago

Hi I didn't get a chance to work on this. If it's urgent someone else can take this up. I won't be able to work on it until end of next week.

wlach commented 6 years ago

I probably won't have time to work on this until at least then, so please feel free to pick this up still. I'll comment on this bug if the situation changes.