mozilla / missioncontrol

Real-time monitoring of Firefox release health
Mozilla Public License 2.0
21 stars 18 forks source link

Some code in the measure tables tests are time-dependent, causing jest tests to fail #338

Closed wlach closed 5 years ago

wlach commented 6 years ago

The just-landed #336 is failing CI:

https://circleci.com/gh/mozilla/missioncontrol/992?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

It appears that some parts of the measure table code are time-dependent. We should something like the strategy here to make sure a consistent result is returned by the react component:

https://jestjs.io/docs/en/snapshot-testing#2-tests-should-be-deterministic

@kagehina919 could you take a look at doing this? I think it should be pretty easy.