search

mozilla / missioncontrol

Real-time monitoring of Firefox release health
Mozilla Public License 2.0
21 stars 18 forks source link

Fix: Don't display measureTable when measures is empty #341

Closed kagehina919 closed 5 years ago

kagehina919 commented 6 years ago

Added patch for #335.

I have added test for the same but the generated snapshot doesn't contain measureTable component. I've used mount instead of shallow rendering.

@wlach could you please help me with this?

kagehina919 commented 5 years ago

@wlach The tests are were failing as the promise required for this.props.fetchChannelPlatformSummaryData() is was not being resolved until after the tests have run.

kagehina919 commented 5 years ago

@wlach issue fixed. Please review.

kagehina919 commented 5 years ago

@wlach could you please take a look at this? :sweat_smile:

wlach commented 5 years ago

Sorry! Was away for a week and away from a computer and forgot to let you know, will take a look first thing tomorrow.

On Sun, Dec 9, 2018, 14:55 kagehina919 <notifications@github.com wrote:

@wlach https://github.com/wlach could you please take a look at this? 😅

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mozilla/missioncontrol/pull/341#issuecomment-445566179, or mute the thread https://github.com/notifications/unsubscribe-auth/AABQWQsqLm4xrS1_N34wW89UIHlWlRXoks5u3WqjgaJpZM4Y3cG9 .

wlach commented 5 years ago

This looks and works great! I will merge.