mozilla / missioncontrol

Real-time monitoring of Firefox release health

Mozilla Public License 2.0

21 stars 18 forks source link

Add back version.json for dockerflow #83

Closed whd closed 7 years ago

whd commented 7 years ago

Fallout from https://github.com/mozilla/missioncontrol/pull/39/, we need this file to rebuild dev for the celery changes.

codecov-io commented 7 years ago

Codecov Report

Merging #83 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #83   +/-   ##
=======================================
  Coverage   48.21%   48.21%           
=======================================
  Files          14       14           
  Lines         280      280           
  Branches       31       31           
=======================================
  Hits          135      135           
  Misses        143      143           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58e3c00...9bbff46. Read the comment docs.

wlach commented 7 years ago

Sorry about breaking this. I later found out there is a more universally accepted way to not send all the things to the docker container -- using a .dockerignore file. @whd - do you want doing that instead? That approach hopefully won't break local development.

Example:

https://github.com/mozilla/telemetry-batch-view/pull/267

whd commented 7 years ago

@wlach I updated the PR to ignore version.json and added a touch to the build script to avoid breaking local environments. However, .dockerignore sounds like the right way to go.

whd commented 7 years ago

@wlach I'm going to close this, please file a PR with the recursive copy and a .dockerignore file since I'm not sure which files you wanted to exclude.