mozilla / mod_authnz_persona

A persona authentication module for apache
Apache License 2.0
23 stars 15 forks source link

Autoconf work #13

Closed gozer closed 11 years ago

gozer commented 11 years ago

Once this is added, you can simply build with:

$> ./buildconf $> ./configure $> make

djc commented 11 years ago

That's a lot of stuff, thanks for trying to move this thing forward.

I've extracted the license addition into caed38c1, rebased your -Wno-unused-function change as d61cf35c and pushed them to master.

For the other stuff, can you elaborate a little more on what bringing autotools in here buys us? It seems like we get by quite well with just the little Makefile so far. I know autotools is a standard thing that many projects use, but it's also kind of a pain to deal with, so it would be good to at least have a clear picture of why we have to deal with it. Also, something more minimal would be nice to start with.

As for the test framework, I'm not sure Perl is the best language for this? At least the issue merits a slightly broader discussion, IMO. I would intuitively grasp for Python. @lloyd?

phrawzty commented 11 years ago

As for the test framework, I'm not sure Perl is the best language for this?

There is an argument to be made that Perl is "more standard" than Python from an OS perspective, which is to say that one is somewhat more likely to have a version of Perl which is "current" (or at least "modern enough") than the same in Python. I'm not sure that this argument is enough to support a decision either way, but it remains a valid observation nonetheless. :)

djc commented 11 years ago

There is an argument to be made that Perl is "more standard" than Python from an OS perspective

I'm not sure I agree. It surely was the case some years ago, but these days I see a lot more Python being used than Perl. So I guess it depends on the perspective or the kinds of boxes, not an automatically-valid observation.

lloyd commented 11 years ago

I understand both positions. I think @djc's question is key: what problem does autotools solve here?