search

mozilla / mofo-allhands

Event App for Mozilla Foundation All Hands
http://mzl.la/mofolondon
Mozilla Public License 2.0
0 stars 7 forks source link

On Search put focus on input #33

Closed xmatthewx closed 8 years ago

xmatthewx commented 8 years ago

Not absolutely essential, but a real nice feature on mobile.

xmatthewx commented 8 years ago

aside: If you make these improvement here, will you need to migrate them back to the core app? In London, let's revisit the architecture topic and think about db, react, node, etc.

mmmavis commented 8 years ago

Since the allhands app is hotlinking the schedule.js on https://github.com/mozilla/schedule-app-core, for changes like this (changes we want to apply to all schedule apps) I will only have to update the schedule.js on the core repo.

Gonna do that now since it's just dropping one additional line of code there!

mmmavis commented 8 years ago

@xmatthewx this change is live now. I tested it on my iPhone - autofocusing the search field causes the screen to zoom in to that field. Feel a little weird to see that instant zoom happen right after I switched to the Search Tab. Umm...

xmatthewx commented 8 years ago

Zoom might feel a little weird. Is the input field not already full width? Are you on iOS?

Focus and opening keyboard is standard behavior after tapping search on Android. I like how our implementation feels on my device.

The font-size in the input field is crazy tiny. 🔬 🔍 👀

screenshot 2016-06-10 00 07 35
xmatthewx commented 8 years ago

This is done. 😄

mmmavis commented 8 years ago

img_1279

This is what iPhone 6 (Safari) is like after I tapped the Search Tab. Input field is full width it's just the instant zoom feels weird.

mmmavis commented 8 years ago

solution suggested by someone on the Internet: set input box font size to 16px

mmmavis commented 8 years ago

OMG 16px IS THE TRICK! https://github.com/mozilla/schedule-app-core/commit/76049808b8c8d5873f59c960768ce6ab21a295c1

issue fixed! 😸