Closed Mozilla-GitHub-Standards closed 5 years ago
@Pomax @cadecairos @gideonthomas @patjouk any idea why Travis is failing on this?
it's not - this is such an old project that it's hitting the fact that it cannot compile nan
against the node version used. We should probably archive this repo.
Except we still use this project in the foundation site.
looks like node-sass needs an update here. Min version of node-sass to use with node 11 is 4.10...we're using 4.5. On the other hand, should we also switch from node 11 to node lts? (10.x)
@alanmoo archiving does not stop that from working. It just means we are never going to work on this again, new issues can't be filed, etc.
I'm also quite curious how much we're still using at this point, given all the sass rewriting we've been doing. I half suspect at this point it's "almost nothing".
I'm also quite curious how much we're still using at this point, given all the sass rewriting we've been doing. I half suspect at this point it's "almost nothing".
100% agreed (other than the grid), but I'm not sure we have the time to find that out right now 😕
In that case, as a non-code PR that literally changes nothing about how this builds, runs CI, etc, I'm just merging this in. An .md
file does not change code state.
Fixes #132
As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:
If you have any questions about this file, or Code of Conduct policies and procedures, please see Mozilla-GitHub-Standards or email Mozilla-GitHub-Standards+CoC@mozilla.com.
(Message COC002)