search

mozilla / morgothv1

Service that helps developers manage the deployment pipeline for System Add-ons.
Mozilla Public License 2.0
0 stars 8 forks source link

Addon groups UI #13

Closed rehandalal closed 8 years ago

rehandalal commented 8 years ago

r?

mythmon commented 8 years ago

My eyes sort of glazed over, but I don't see any other issues

rehandalal commented 8 years ago

Circle ain't happy with this either:

===============================================================================
FAILED: eslint
===============================================================================
The react/require-extension rule is deprecated. Please use the import/extensions rule from eslint-plugin-import instead.

/app/client/ui/components/AddonGroupForm.jsx
  4:27  error  Unable to resolve path to module 'redux-form-material-ui'  import/no-unresolved

/app/client/ui/components/AddonForm.jsx
  4:27  error  Unable to resolve path to module 'redux-form-material-ui'  import/no-unresolved

✖ 2 problems (2 errors, 0 warnings)
rehandalal commented 8 years ago

After much painful digging I was able to figure out the issue... https://github.com/erikras/redux-form-material-ui/pull/32

mythmon commented 8 years ago

Wow, that's intense. Nice job finding it. I wonder why it worked fine for me? If you want to go ahead and keep the eslint change to a warning until that PR merges, go for it. I don't have any other comments about this, for better or worse. r+