search

mozilla / morgothv1

Service that helps developers manage the deployment pipeline for System Add-ons.
Mozilla Public License 2.0
0 stars 8 forks source link

ESLint #3

Closed rehandalal closed 8 years ago

rehandalal commented 8 years ago

@mythmon quick r?

eslint will fail right now but it will be fixed by my UI branch

mythmon commented 8 years ago

I'm hesitant to use pre-commit. It burned us a few times on Kitsune, since it uses it's own virtualenv. I don't have any better ideas though.

mythmon commented 8 years ago

This looks good to me, and I confirmed the only failure in CI is the eslint part. There is only one lint failure here. I would fix it before merging.