mozilla / morgothv1

Service that helps developers manage the deployment pipeline for System Add-ons.
Mozilla Public License 2.0
0 stars 8 forks source link

Update node-sass to version 3.9.3 πŸš€ #32

Closed greenkeeperio-bot closed 7 years ago

greenkeeperio-bot commented 7 years ago

Hello lovely humans,

node-sass just published its new version 3.9.3.

State Update :rocket:
Dependency node-sass
New version 3.9.3
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of node-sass. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project :sparkles:

You rock!

:palm_tree:


GitHub Release

Fix filename issues πŸš‘

In v3.9.0 we began publishing our test suite to npm as part of our release. We did this be compliant with the node-citgm project. Being the citgm would give us early warning of changes in Node that would break Node Sass for users. We'd hoped this would allows to address these issue early and avoid the dozens of bug reports we receive.

However some users have experience issues with some test filenames include unicode characters. Some npm@2 users have also experienced issues with our path names being too long.

As a result we're temporarily reverting the addition of our test suite until we have a solution for these issues.

We're sorry πŸ’–

Noone ever wants to break someone's build. We had expected this minor change to be innocuous.

Unfortunately we had not accounted for the variety of operating environments our +2M monthly downloads would be running on. Although the number of affected users was small, the failure was at times catastrophic.

Having this feature is important to us, but not breaking your builds, and workflows is critical.


The new version differs by 46 commits .

There are 46 commits in total. See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? :zap: greenkeeper upgrade