mozilla / morgothv1

Service that helps developers manage the deployment pipeline for System Add-ons.
Mozilla Public License 2.0
0 stars 8 forks source link

Issue 46 balrog sync #55

Closed rhelmer closed 7 years ago

rhelmer commented 7 years ago

@rdalal Putting this up for discussion to make sure it's the direction we want to go - note the FIXMEs :) Some more context below, but just hoping to know if this is the sort of thing you had in mind.

I just did the bare minimum to get the existing "Sync" button to work in React for local testing purposes, I did not attempt to move it from its current location so that still needs to be done.

After discussion with @mozbhearsum in IRC earlier:

We also discussed whether removing all Morgoth-created rules was the right thing to do - I agree that it's not ideal, but for an MVP it's reasonable.

Once we have Balrog reading and sync diff sorted out I think it'll be easy to fix it so that we only remove and modify releases+rules where needed.

rhelmer commented 7 years ago

Some notes from in-person review w/ @rehandalal

Osmose commented 7 years ago

I suspect this is not necessary anymore what with #65 and all. Closing.