search

mozilla / morgothv1

Service that helps developers manage the deployment pipeline for System Add-ons.
Mozilla Public License 2.0
0 stars 8 forks source link

Move client side files out of Django project #9

Closed rehandalal closed 8 years ago

rehandalal commented 8 years ago

Similar to the open pull on Normandy.

r?

mythmon commented 8 years ago

Functionally, when running this branch, the UI's navigation doesn't seem to work, and I get errors (not just proptypes) in the console. I think those errors also exist on master though.

Style wise, in Normandy, instead of client/ui/js/index.js, I had client/ui/index.js. I think that made inter-app imports simpler (import foo from '../../ui/foo.js'; instead of import foo from '../../ui/js/foo.js). I think it reads cleaner.

rehandalal commented 8 years ago

Have changed the file structure to match normandy. So now there is no more client/ui/js.

mythmon commented 8 years ago

r+