mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
9 stars 13 forks source link

Prefilter Data Sources using experiment annotation where available #169

Closed danielkberry closed 1 year ago

danielkberry commented 1 year ago

This builds off of the ideas that @scholtzan came up with for the abouthome-startup-cache experiment, namely: we can pre-filter data sources that have experiment annotations down to only data from the appropriate experiment, thus reducing the amount of work necessary when joining data sources together.

danielkberry commented 1 year ago

@scholtzan What's the procedure from here? Can I just merge this or should we test it somehow?

scholtzan commented 1 year ago

In an ideal world we'd add a test for this in https://github.com/mozilla/mozanalysis/blob/main/tests/test_metrics.py But in this reality, we've usually been neglecting tests a bit. So merging as is is probably fine