Closed m-d-bowerman closed 4 months ago
Is there a straightforward way to identify data sources you can think of? If we assume all metrics and data sources are being created from metric-hub
we could just add the application name as an attribute to the Metric and Segment classes, but how do we handle the case where from_expr
is used to generate a Metric or Segment?
I'll give this some more thought. One thing that came to mind was checking the datasets returned when running get_single_window_data
, to see if there are any columns in that set with all 0 values, which would happen if the apps mismatched.
Currently, no warning is raised when Metrics and Segments are using data sources that rely on different applications' datasets. A check should be added in
sizing.py
for a mismatch between data sources.