mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
10 stars 13 forks source link

Remove parens in metric query #175

Closed scholtzan closed 1 year ago

scholtzan commented 1 year ago

This was causing Syntax error: Expected keyword JOIN but got ")"

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf56c5d) 75.95% compared to head (f285301) 75.95%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #175 +/- ## ======================================= Coverage 75.95% 75.95% ======================================= Files 23 23 Lines 965 965 ======================================= Hits 733 733 Misses 232 232 ``` | Flag | Coverage Δ | | |---|---|---| | py38 | `75.95% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/mozilla/mozanalysis/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [src/mozanalysis/metrics/\_\_init\_\_.py](https://codecov.io/gh/mozilla/mozanalysis/pull/175?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#diff-c3JjL21vemFuYWx5c2lzL21ldHJpY3MvX19pbml0X18ucHk=) | `91.46% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.