mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
10 stars 13 forks source link

Metric query construction for sizing finds 0 clients when default dataset passed #180

Closed m-d-bowerman closed 1 year ago

m-d-bowerman commented 1 year ago

The problem is in the from_expr_for method: if a default dataset is passed to the DataSource class, the method build_query_targets that builds the metrics query for sizing jobs will return a query that attempts to search for an experiment slug. This is solved by adding a condition here that returns from the function when no experiment slug is passed.