Closed mikewilli closed 11 months ago
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
93b8644
) 75.96% compared to head (00a40d3
) 75.96%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What would an end-to-end test of this look like for jetstream config files? Like, how do we test that when someone sets this parameter in a custom config that the expected enrollments SQL query is generated
Good question. I don't see why we couldn't test for the sample_id <= {value}
inside jetstream as it contains mozanalysis as a dependency, with a mock for the object that would've been parsed from the config. Then we can also have separate tests for parsing it from the config.
Adds a
sample_size
parameter to the functions building enrollments queries. This will allow us to update metric-hub configs to support easier downsampling without having to redefine the entire enrollments query. From the config, jetstream can retrieve this sample size and pass it into mozanalysis when building the enrollments query.