fix #189: explicitly set sample_size to 100 if unset or None

mozilla / mozanalysis

A library for Mozilla experiments analysis

https://mozilla.github.io/mozanalysis/

Mozilla Public License 2.0

9 stars 13 forks source link

fix #189: explicitly set sample_size to 100 if unset or None #190

Closed mikewilli closed 10 months ago

mikewilli commented 10 months ago

The unset None value was be propagated down into the query, causing an issue when the query tried to run sample_id < None.

I also noticed that I had sample_id <= instead of < in the queries, which could be confusing (sample_size of 10 would actually be an 11% sample with <=), so I fixed that.