Closed jaredsnyder closed 6 months ago
For the simplest methods that just return a dict of dicts I created SampleSizeResultsHolder
. It is just an extension of the dict class that has some extra methods and attributes, but is set up so that if you interact with it like a dict it works exactly the same as it did before. Added a nice graphing function where the output looks like this:
Attention: Patch coverage is 93.04348%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 81.43%. Comparing base (
2df08a3
) to head (3a6524d
).
Files | Patch % | Lines |
---|---|---|
src/mozanalysis/frequentist_stats/sample_size.py | 93.04% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This is what the pretty_results
function output looks like
these are just some spelling corrections I came across while browsing. this isn't a code reveiw. if you would like an extra set of eyes, i can do so
Whoops, thanks for catching that! Pushed a commit to fix.
This PR is adding wrapper classes for results returned from the objects in sample_size_calc.py. The idea is to add functionality to make it easier to work with results while maintaining backward compatibility
Fixes #204