mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
9 stars 13 forks source link

Clarify custom_enrollments_query docs #207

Closed mikewilli closed 4 months ago

mikewilli commented 5 months ago

These docs are a bit confusing and incomplete for custom_enrollments_query:

A full SQL query to be used in the main query:

`WITH raw_enrollments AS ({custom_enrollments_query})`

N.B. this query’s results must be uniquely keyed by (client_id, branch), or else your results will be subtly wrong.

This text (or similar) is copied for multiple functions within this package, any updates should be made to all relevant function docs.

We should make the following updates to clarify: