Closed jaredsnyder closed 4 months ago
I believe the to_dataframe
method already does this under the hood, based on the create_bqstorage_client
parameter that defaults to true. I guess passing the client explicitly does avoid creating that client each time the to_dataframe
method is called.
I believe the
to_dataframe
method already does this under the hood, based on thecreate_bqstorage_client
parameter that defaults to true. I guess passing the client explicitly does avoid creating that client each time theto_dataframe
method is called.
Lol think we can just close this PR and the issue then
Fixes #77
I had a hard time figuring out how to best use the API and given the age of the story it might be out of date. I ran an experiment where I locally ran the following code on this branch and on main:
I used the jupyter
%%timeit
magic to measure how fast. On main it ran in37.4 s ± 8.17 s per loop (mean ± std. dev. of 7 runs, 1 loop each)
while on the feature branch it ran in31.3 s ± 1.4 s per loop (mean ± std. dev. of 7 runs, 1 loop each)
. Not very scientific, especially given the std deviation on the main, but it looks like the improvement is fairly minor in this case.