Closed jaredsnyder closed 3 months ago
Attention: Patch coverage is 94.73684%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 80.64%. Comparing base (
2df08a3
) to head (79ff51b
).
Files | Patch % | Lines |
---|---|---|
src/mozanalysis/sizing.py | 93.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The other thing that occurred to me is that using "source" in the warnings might be ambiguous -- users might take it to mean multiple DataSource
s are causing the warnings. I think using "app" might be more informative (e.g. segments and metric do not have a common app
)
The other thing that occurred to me is that using "source" in the warnings might be ambiguous -- users might take it to mean multiple
DataSource
s are causing the warnings. I think using "app" might be more informative (e.g.segments and metric do not have a common app
)
Good catch, fixed it
Fixes #173
app_name
attribute to Metric, Segement, etc classes so that sources from metric-hub can be checked