Closed jaredsnyder closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.45%. Comparing base (
adeb867
) to head (58e3927
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do we want to use this PR to clean up the tox.ini? It looks significantly different than jetstreams. If so I'll need some help understanding the difference probably.
I don't think the differences are a concern. I don't see any differences that are important to change, and changes would probably be made to the jetstream side if anything (e.g., incorporate rust).
Do we need to build a universal wheel given we don't support python2?
No, not as far as I understand at least.
This is a PR to improve the dependency management by adding a
requirements.txt
file autogenerated by a script viapip-tools
. More details in the ADR 0001 doc indocs/adrs
. Added apyproject.toml
to consolidate a lot of the config too.Non-exhaustive list of things I need reviewers to double-check:
setup.cfg
andsetup.py
that we need got left out of thepyproject.toml
. There was some stuff that seemed irrelevant (IE all theisort
config from thesetup.cfg
which we don't seem to be using) so make sure that is actually irrelevant.Also questions:
tox.ini
? It looks significantly different than jetstreams. If so I'll need some help understanding the difference probably.Fixes #202