mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
9 stars 13 forks source link

Improving dependency management as per ADR 0001 #228

Closed jaredsnyder closed 1 month ago

jaredsnyder commented 1 month ago

This is a PR to improve the dependency management by adding a requirements.txt file autogenerated by a script via pip-tools. More details in the ADR 0001 doc in docs/adrs. Added a pyproject.toml to consolidate a lot of the config too.

Non-exhaustive list of things I need reviewers to double-check:

Also questions:

Fixes #202

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.45%. Comparing base (adeb867) to head (58e3927). Report is 9 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #228 +/- ## ======================================= Coverage 84.45% 84.45% ======================================= Files 24 24 Lines 1267 1267 ======================================= Hits 1070 1070 Misses 197 197 ``` | [Flag](https://app.codecov.io/gh/mozilla/mozanalysis/pull/228/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [project](https://app.codecov.io/gh/mozilla/mozanalysis/pull/228/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `84.45% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mikewilli commented 1 month ago

Do we want to use this PR to clean up the tox.ini? It looks significantly different than jetstreams. If so I'll need some help understanding the difference probably.

I don't think the differences are a concern. I don't see any differences that are important to change, and changes would probably be made to the jetstream side if anything (e.g., incorporate rust).

Do we need to build a universal wheel given we don't support python2?

No, not as far as I understand at least.