mozilla / mozanalysis

A library for Mozilla experiments analysis
https://mozilla.github.io/mozanalysis/
Mozilla Public License 2.0
9 stars 13 forks source link

chore: more precise errors in tests; README typos #270

Closed mikewilli closed 1 month ago

mikewilli commented 1 month ago

Was playing around with the tests for something else and noticed that we were checking for Exception when we could be more specific. Also saw some extremely minor typos in the README that I fixed for consistency.

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.66%. Comparing base (3c47d60) to head (e051d5b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #270 +/- ## ======================================= Coverage 83.66% 83.66% ======================================= Files 19 19 Lines 1353 1353 ======================================= Hits 1132 1132 Misses 221 221 ``` | [Flag](https://app.codecov.io/gh/mozilla/mozanalysis/pull/270/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [project](https://app.codecov.io/gh/mozilla/mozanalysis/pull/270/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `83.66% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.