mozilla / mozilla-django-oidc

A django OpenID Connect library
https://mozilla-django-oidc.readthedocs.io
Mozilla Public License 2.0
445 stars 166 forks source link

LOGIN_REDIRECT_URL should accept an URL or named URL pattern #452

Closed dispiste closed 2 years ago

dispiste commented 2 years ago

LOGIN_REDIRECT_URL is a general django setting. According to Django docs, it should accept an URL or named URL pattern (see https://docs.djangoproject.com/en/stable/ref/settings/#login-redirect-url). However, if we use a named URL pattern, mozilla-django-oidc does not work properly.

The solution uses django.shortcuts resolve_url method, which is not publish API as far as I know. However, it is available at least in Django 2.2 to 4.x.