search

mozilla / mozillafestival.org

The Mozilla Festival site
https://mozillafestival.org
Mozilla Public License 2.0
31 stars 24 forks source link

CFP Close 2018 #1035

Closed mmmavis closed 6 years ago

mmmavis commented 6 years ago

https://github.com/mozilla/mozillafestival.org/labels/2018%20CFP%20Close

mmmavis commented 6 years ago

@sabrinang can you review to make sure I got all the updates in?

sabrinang commented 6 years ago

@mmmavis

1018

962

926 Tickets page

Copy looks good to me and functionality for video and ticket modals are working.

mmmavis commented 6 years ago

1018 remove proposals from navigation (it is still there)

Done

962 Design feedback: Add padding on top of yellow GET TICKETS button to balance space with bottom.

Top and bottom paddings of the button are actually the same. I'm unable to track down why the text itself comes with more spaces at the bottom. I will fix it if I'm able to find out why but I don't want this to be the blocker for today's push.

926 Tickets page - Can buttons have bolder 2px stroke and bold type for Buy Ticket (looks like it is in helvetica but check if it is fira sans)

I'm using existing "btn-primary-outline" style for the "Buy Ticket" button ( e.g., also seen on https://mozillafestival-org-st-pr-1035.herokuapp.com/fringe ). Do you want the style changes (bolder 2px stroke and bold type) to be applied to all "btn-primary-outline" buttons on the site or just these ones on the /tickets page?

Can you link me to the design file (.ai? .sketch?) so I can reference to the exact stylings. It's hard for me to tell from flat jpeg or png files especially mockups on Redpen are kinds small. Thanks!

mmmavis commented 6 years ago

@sabrinang ^^

sabrinang commented 6 years ago

@mmmavis If it is using existing styles let's go with that and not let the design tweaks be a blocker. Thanks for removing proposals from the nav 👍