search

mozilla / mozillians-tests

DEPRECATED - Mozillians Tests
http://www.mozillians.org
Other
51 stars 74 forks source link

Fixed "RemovedInPytest4Warning" error #527

Closed viorelaioia-zz closed 5 years ago

viorelaioia-zz commented 5 years ago

removed tests failing with "RemovedInPytest4Warning: Fixture "login_link" called directly." error after pytest upgrade.

stephendonner commented 5 years ago

Thanks, @viorelaioia - looking good, but can you also land a fix to the now-unused import?

pipenv run flake8
./tests/conftest.py:10:1: F401 'tests.restmail' imported but unused
viorelaioia-zz commented 5 years ago

@stephendonner , I addressed your comment! Thanks!

stephendonner commented 5 years ago

Thanks, @viorelaioia - according to Jenkins[0], there is still this other error:

08:18:43 [mozillians_PR-527-WXAW444AARCYNLIPKXVAGVRG7LDDTDLRIPRQD46GC6BCJFUGA4XA@2] Running shell script

08:18:43 + pytest -n=auto --tb=short --color=yes --driver=SauceLabs --variables=capabilities.json --variables=**** --junit-xml=results/junit.xml --html=results/index.html --self-contained-html --log-raw=results/raw.txt --log-tbpl=results/tbpl.txt
Post stage
08:18:44 Traceback (most recent call last):
08:18:44   File "/usr/local/bin/pytest", line 11, in <module>
08:18:44     sys.exit(main())
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 61, in main
08:18:44     config = _prepareconfig(args, plugins)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 196, in _prepareconfig
08:18:44     pluginmanager=pluginmanager, args=args
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/hooks.py", line 284, in __call__
08:18:44     return self._hookexec(self, self.get_hookimpls(), kwargs)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 67, in _hookexec
08:18:44     return self._inner_hookexec(hook, methods, kwargs)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 61, in <lambda>
08:18:44     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 203, in _multicall
08:18:44     gen.send(outcome)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/helpconfig.py", line 93, in pytest_cmdline_parse
08:18:44     config = outcome.get_result()
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 81, in get_result
08:18:44     _reraise(*ex)  # noqa
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/callers.py", line 187, in _multicall
08:18:44     res = hook_impl.function(*args)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 652, in pytest_cmdline_parse
08:18:44     self.parse(args)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 838, in parse
08:18:44     self._preparse(args, addopts=addopts)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/config/__init__.py", line 784, in _preparse
08:18:44     self.pluginmanager.load_setuptools_entrypoints("pytest11")
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pluggy/manager.py", line 267, in load_setuptools_entrypoints
08:18:44     plugin = ep.load()
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2346, in load
08:18:44     return self.resolve()
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pkg_resources/__init__.py", line 2352, in resolve
08:18:44     module = __import__(self.module_name, fromlist=['__name__'], level=0)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/_pytest/assertion/rewrite.py", line 308, in load_module
08:18:44     six.exec_(co, mod.__dict__)
08:18:44   File "/usr/local/lib/python2.7/dist-packages/six.py", line 709, in exec_
08:18:44     exec("""exec _code_ in _globs_, _locs_""")
08:18:44   File "<string>", line 1, in <module>
08:18:44   File "/usr/local/lib/python2.7/dist-packages/pytest_selenium/drivers/testingbot.py", line 6, in <module>
08:18:44     from _pytest.mark import MarkInfo
08:18:44 ImportError: cannot import name MarkInfo

[0] https://qa-preprod-master.fxtest.jenkins.stage.mozaws.net/job/mozillians/view/change-requests/job/PR-527/6/console

viorelaioia-zz commented 5 years ago

@stephendonner , I updated the pytest-selenium version to the latest one and this issue seems fixed (as per suggestions here). Tests are passing now.

stephendonner commented 5 years ago

@viorelaioia right you are, thanks!