mozilla / mozjpeg

Improved JPEG encoder.
Other
5.47k stars 414 forks source link

consider providing binary releases #91

Open bdaehlie opened 10 years ago

bdaehlie commented 10 years ago

I was hoping to avoid doing this to keep project overhead low (having to make formal builds on a bunch of platforms every time we release), but based on feedback we probably need to consider making binaries available for popular platforms.

dwbuiten commented 10 years ago

Would it be worth it to include package recipes for RPMs and DEBs? Or are you banking on the maintainers in distros packaging mozjpeg?

vrubleg commented 10 years ago

Please provide binaries for Windows at least.

dwbuiten commented 10 years ago

I don't mind providing these with any of the 3 common compilers (Intel, MSVC, or MinGW), but I'm sure Mozilla can provide some official builds + import libs for 3.0

rahulsundaram commented 10 years ago

FWIW, I have built a RPM for Fedora. Review at https://bugzilla.redhat.com/show_bug.cgi?id=1154163. Unlikely to get into the repo at this point till the ABI compatibility issues are resolved but it is a starting point for those looking for a package.

bdaehlie commented 9 years ago

We can continue to consider releasing official binaries but this doesn't need to block the 3.0 release, unblocking.

dwbuiten commented 9 years ago

@bdaehlie I can provide Visual Studio and/or Intel Compiler builds for 3.0 if it is still desired.

Ferk commented 9 years ago

Are there any Windows builds available?

CoolOppo commented 9 years ago

@Ferk You can use my build if you need it.

The software is provided "as is", without warranty of any kind, express or implied, including but not limited to the warranties of merchantability, fitness for a particular purpose and noninfringement. In no event shall the authors or copyright holders be liable for any claim, damages or other liability, whether in an action of contract, tort or otherwise, arising from, out of or in connection with the software or the use or other dealings in the software.

You can download it here: https://visionless.me/u/mozjpeg.exe

RyanBram commented 9 years ago

Is it possibe to use buildbot for automate this task? Some emulator project use it for every update.

In case somebody still looking for pre-compiled binaries, this site provide unofficial build: http://mozjpeg.codelove.de/binaries.html

magnetikonline commented 9 years ago

For a little self promotion. Have put together a Dockerfile - which produces a Debian .deb package as output. Builds 3.0 release too.

https://github.com/magnetikonline/dockermozjpegdeb

ErtugKaya commented 9 years ago

Please provide official binaries, especially for Windows.

@CoolOppo Avast claims that your binary has a virus.

CoolOppo commented 9 years ago

@ErtugKaya What is the specific message it says? I'm the one who built that, and I didn't do anything bad to it. Either the file got tampered with, or Avast is wrong, and I'm going to stick with the latter.

ErtugKaya commented 9 years ago

@CoolOppo Avast claimed it is infected with a virus and blocked my download. I am sorry, I cannot recall the virus name. I look for a history for web shield, it seems Avast don't log web shield alarms. It's blocking that link now. So it won't warn me again.

I believe that is a false positive too.

Update: Just this second, I stopped Avast Web Shield to be able to download the file, and do a scan on file. It says it is clean. Definitely false alarm.

tomByrer commented 8 years ago

Windows binaries would be great. @dwbuiten I'd prefer Intel builds; they tend to run the fastest.

TPS commented 7 years ago

It's been > 2200 commits since last binary release, which seems awfully strange, since all previous releases were done ~every 500 commits or so. Could we get a new binary release, &, even better, a bit of a firm commitment on more regular releases (even if just ßs!), please? :bow:

kornelski commented 7 years ago

It would be good to make another release, but Josh Aas is now busy with Let's Encrypt, and making another release is up to volunteers.

The new commits are almost exclusively from updating libjpeg-turbo, and there aren't any major updates to mozjpeg itself. However, we need to ensure that there weren't any regressions in terms of bugs as well as filesize/quality ratio.

Either way, for now you'll have to look for binaries provided by others (Linux distributions, and projects using MozJPEG internally).

TPS commented 7 years ago

I couldn't find anyone with current daily/ß Windows binaries (especially 64-bit).… Any suggestions/leads?

vatterspun commented 7 years ago

Just a quick note that this came up on another case here on Github: https://github.com/ShareX/ShareX/issues/2270#issuecomment-277997848

JosePineiro commented 7 years ago

You have windows binaries in https://encode.ru/threads/1892-mozjpeg

TPS commented 7 years ago

@JosePineiro Official binaries are important, as, especially @ the time this was posted, even unofficial 1s are few & far between.

kornelski commented 7 years ago

There are no official binaries.

The main reason is that I don't know Windows enough to properly build libraries for Windows. I've tried providing binaries for pngquant before, and it's been an awful experience.

(There's no need to build for other platforms, since Linux package managers and Homebrew are a better way to install libraries.)

The second reason is that nobody should even need a MozJPEG binary. The intended way to use MozJPEG is via 3rd party programs. We'd like tools like ImageMagick, GIMP, Sketch, etc. to seamlessly compile/link MozJPEG into their binaries, so that end users never download anything from us. MozJPEG is specifically designed to be easily built-in into "Save As" command of almost any program that writes JPEGs.

I know this hasn't happened, so a lot of people are resorting to the cjpeg tool (sometimes renamed to mozjpeg by 3rd parties) and consider that to be the way to use MozJPEG. But that tool is not MozJPEG. It's more like a demo program using the library. It's rather basic, cumbersome and integration via external files is much less efficient than the native C API.

CoolOppo commented 7 years ago

@pornel want me to make a quick video of how to compile MozJPEG on Windows? I know you could figure it out, but if it'd help I'll do it since I compile it all the time anyways.

Edit: I also agree with @TPS. It's important to provide official binaries, at least for Windows.

kornelski commented 7 years ago

What would be useful is if you set up a Continuous Integration servers that make Windows binaries for the master branch and all tags (exe as well as libjpeg.dll/turbojpeg.dll for popular versions of VS runtimes and MinGW, 32 and 64-bit), especially if you could package that setup as some form of image/script that can be used to rebuild it in another place later.

CoolOppo commented 7 years ago

@pornel I'll see what I can do with AppVeyor. I don't think it supports MinGW, but it can spit out static binaries that won't depend on msvc***.dll.

vrubleg commented 7 years ago

CoolOppo, BTW, it is possible to use msvcrt.dll (preinstalled since Windows 98) from the Visual Studio 2013 + WDK (it provides *.lib files for such purpose). It could be useful.

CoolOppo commented 7 years ago

Well...that was surprisingly easy!

I figured out how to make it clone the official repo and build it from there, here it is! https://ci.appveyor.com/project/CoolOppo/mozjpeg-svdl6/build/artifacts Build status

TPS commented 7 years ago

Could someone comment on how these compare to, say, binaries from?:

(@javiergutierrezchamorro Please be aware of these new binaries to use in FileOptimizer:

https://ci.appveyor.com/project/CoolOppo/mozjpeg-svdl6/build/artifacts)

TPS commented 7 years ago

@CoolOppo I forgot to say thanks! :bow: Could you have 64-bit binaries built, too, though?

javiergutierrezchamorro commented 7 years ago

Thanks @TPS Have now updated the x86 build on FileOptimizer. Will do with the x64 one if @CoolOppo builds a Win64 one.

kornelski commented 7 years ago

Thanks. Could you also build the actual library? libjpeg.{dll,a}?

CoolOppo commented 7 years ago

Thanks. Could you also build the actual library? libjpeg.{dll,a}?

Yeah, I'll try and get that set up right now.

Could you have 64-bit binaries built, too, though?

I'll see what I can do :)

JosePineiro commented 7 years ago

I make this c# wrapper: https://github.com/JosePineiro/MozJpeg-wrapper You have the 32 and 64 bits compiled DLL (the turbojpeg.dll) of version 3.2 Is the most easy API

TPS commented 7 years ago

@JosePineiro Any luck re: x64 .exe's?

javiergutierrezchamorro commented 7 years ago

Thanks, but I am interested in static EXE.

jan-dh commented 7 years ago

Would love some official binaries. Need to use this server-side for uploaded images

garyzyg commented 6 years ago

Hi @kornelski,

I've created one project mozjpeg-windows to build mozjpeg binaries (for Win32 & Win64), which are linked to msvcrt.dll without additional .dll. If you would like to do similar jobs officially, you may take a look at it.

Gary

dofuuz commented 4 years ago

I have built 4.0.1-rc windows binary with PNG input support. https://github.com/dofuuz/mozjpeg/releases

Frosty-J commented 2 years ago

In case somebody still looking for pre-compiled binaries, this site provide unofficial build

Unfortunately, that's no more as of sometime in the past year. In the meantime, here's my own build, made on Ubuntu 22.04: mozjpeg_4.0.3_amd64.deb.tar.gz

Would anyone in charge around here be interested in building binaries using GitHub Actions or something? Shouldn't be too hard to set up and would minimise the risks that come with people relying on third-party builds.

dofuuz commented 2 years ago

mozjpeg-v4.1.1-win-x86.zip mozjpeg-v4.1.1-win-x64.zip Here is backup of v4.1.1 automated build artifacts.

vikas5914 commented 1 year ago

If anyone looking for Ubuntu binary, you can easily build using my script: https://gist.github.com/vikas5914/4affccdfa5c3a722808cd465f77866b9

dofuuz commented 1 year ago

mozjpeg-v4.1.4-win-x86.zip mozjpeg-v4.1.4-win-x64.zip Here is backup of v4.1.4 automated build arfitacts. You're welcome. 😉

dofuuz commented 1 year ago

mozjpeg-v4.1.5-win-x86.zip mozjpeg-v4.1.5-win-x64.zip Backup of v4.1.5 automated build arfitacts.