search

mozilla / mozmill-ci

[OBSOLETE] Mozmill CI system driven by Mozilla Pulse and Jenkins
https://wiki.mozilla.org/QA/Automation/Projects/Mozmill_Automation/Mozmill_CI
20 stars 18 forks source link

Remove truncating of revision to 12 characters #843

Closed whimboo closed 7 years ago

whimboo commented 7 years ago

As mentioned by @edmorley on PR #842:

Could you also check for/remove any instances of truncating the revision to 12 characters? We prefer the full 40 characters.

eg:
https://github.com/mozilla/mozmill-ci/blob/e0f6a97f66fc015c20f164096836ea7d0139abe4/jenkins-master/jobs/trigger-ondemand/workspace/trigger.py#L85
https://github.com/mozilla/mozmill-ci/blob/e0f6a97f66fc015c20f164096836ea7d0139abe4/jenkins-master/jobs/trigger-ondemand/workspace/trigger.py#L178
https://github.com/mozilla/mozmill-ci/blob/6a4372c0e78ab491a466d2c5284b67b6f1a59e90/jenkins-master/jobs/scripts/workspace/submission.py#L322
https://github.com/mozilla/mozmill-ci/blob/bc7538268a80a254bb28f7cbd748bc30c95ef68a/lib/automation.py#L265
whimboo commented 7 years ago

PR #844 got merged. Will push to staging now.

edmorley commented 7 years ago

Many thanks! :-)