search

mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.68k stars 331 forks source link

"Always open in container" no effect through toolbar #1174

Open bobzilladev opened 6 years ago

bobzilladev commented 6 years ago

Actual behavior

"Always Open in Container" works right-clicking on page loaded in container, but does not work when going through the toolbar icon -> container's right-arrow -> right-click site -> firefox containers -> always open in container. The checkbox appears, but typing site in new tab does not open it in new tab, and the checkbox is no longer seen on other container'd tabs in that location.

Expected behavior

Either don't show the option in that deep UI path, or make the option persist and work.

Steps to reproduce

  1. Open container tab, say it's called "Twitter"
  2. Go to a site, say "twitter.com"
  3. Click the "Multi-Account Containers" 3 boxes and a + icon on toolbar
  4. Click on the right-arrow next to "Twitter"
  5. Right-click on the twitter site title
  6. Click "Firefox Multi-Account Containers"
  7. Click "Always Open in this Container"
  8. Open a new tab, type in "twitter.com", opens in default container.

Notes

Found by hunting for where to assign the always-open status, since the docs say to right-click the tab, but that doesn't show the option (maybe it should, since it's a tab feature?). You have to right-click on the webpage in the tab, not the tab itself.

lauriefoster2018 commented 6 years ago

My homepage is my gmail email account. I have it set to open in a container but when I start firefox and the homepage opens it is NOT in the correct container. It is in the default container. Y'all need to fix this.

Velarier commented 6 years ago

@lauriefoster2018 I've seen that happen with Facebook due to the URL selected as homepage having a "/ref-something/". Test changing your homepage to the default location, like "https://mail.google.com/". This feedback might be useful to the DEV (but in a different issue?).

vibhas77 commented 6 years ago

So basically what we really want is the ability to store the container value for a given bookmark. For example, many websites may belong to many other containers. And then it is upto the user to "Jail" the website by removing it from default. This way we will be able to manage the issue better.

Implementation Requirements : 1) Be able to store the bookmark's ( or any link's ) container type. 2) Add the websites that you do not want to open in the default container. ( only blacklist, no whitelist ) 3) Add the websites that you want or do not want in any other container ( both blacklist and whitelist )

For example in the first scenario, I have two gmail links on my bookmark, one for work and another for personal and I would want them to open in different containers even though the URL is the same.

I know that this concept sounds strange, difficult to implement or somewhat against the concept of containers, but it offers a better choice to the user as to how they would like to use the containers.

grahamperrin commented 3 years ago

… does not work when going through the toolbar icon … but typing site in new tab does not open it in new tab, …

Is this still an issue?

Please see, for example https://github.com/mozilla/multi-account-containers/issues/1609#issuecomment-825847381