search

mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.67k stars 330 forks source link

Onboarding panels of popup, navigation via keyboard #1538

Open dnahol opened 4 years ago

dnahol commented 4 years ago

Actual behavior

When onboarding panels appear in popup container, (e.g. Get Started), there is no way to proceed through the panels via keyboard.

Screen Shot 2019-10-18 at 1 11 30 AM

Expected behavior

Should be able to press "return" through the onboarding buttons to reach the functioning containers panel.

Steps to reproduce

  1. in terminal, run ./node_modules/.bin/web-ext run -s src/ OR in regular Firefox, uninstall and reinstall Multi-Account Containers Extension
  2. Click on the containers icon in the toolbar

Notes

Name
Version
Enabled
ID

Amazon.com
1.1 true
amazondotcom@search.mozilla.org

Bing
1.0 true
bing@search.mozilla.org

DuckDuckGo
1.0 true
ddg@search.mozilla.org

eBay
1.0 true
ebay@search.mozilla.org

Firefox Multi-Account Containers
6.1.1
true @testpilot-containers

Google
1.0 true
google@search.mozilla.org

Twitter 1.0 true
twitter@search.mozilla.org

Wikipedia (en)
1.0 true
wikipedia@search.mozilla.org

silvererudite commented 4 years ago

I think I can do sth about it @maxxcrawford and @groovecoder. It would be a nice accessibility feature. Since I am just waiting for you guys to review my previous PR.

dnahol commented 4 years ago

Hey @silvererudite , I am in the same situation and actually reported because I am working on it and in submitting a PR soon

silvererudite commented 4 years ago

oh haha sorry abt that...good luck then

olsenme commented 4 years ago

@maxxcrawford my issue fell through. Do you have any other issues I can work on?

dnahol commented 4 years ago

1539 solves this. Closing.

dnahol commented 4 years ago

Found a bug: not possible to open Edit Containers button via Enter key. EditContainersLink Issue

dnahol commented 4 years ago

(bug fixed with #1570)

grahamperrin commented 3 years ago

Onboarding …

… in popup container, (e.g. Get Started), there is no way to proceed through the panels via keyboard.

Onboarding is fixed:

https://user-images.githubusercontent.com/192271/116690607-888a4280-a9b1-11eb-9c19-930c416fa8a2.mp4

@dnahol please, can you close this issue? Thank you.

(You can open separate issues for things that don't match the title of this issue.)