mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.69k stars 331 forks source link

"Limit to designated sites" conflict with other Container addons #2350

Open erosman opened 2 years ago

erosman commented 2 years ago

If "Firefox Multi-Account Containers" is installed and "Limit to designated sites" is enabled (without any sites listed, there will be a conflict with another container addon (FoxyTab).

I am not sure where the exact conflict is as the addons behaviours are not the same. I look forward to feedback and will work on eliminating the issue.

Actual behavior

Expected behavior

Once a tab is opened in a container, there shouldn't be a need for re-navigating it

Notes

Maybe there is a need to limit access when there are more than one addon is handling an API, similar to Network Settings addons :thinking:

erosman commented 2 years ago

It appears that when a container tab is opened by another process and that site is not listed, and siteIsolation is true, addon attempts to remove the tab and re-open it in the default container which creates an endless loop with the other addon.

I would suggest that siteIsolation should only come into effect:

https://github.com/mozilla/multi-account-containers/blob/873ba0ab09bf0ea1adc555e6020a65a4c41c71bb/src/js/background/assignManager.js#L254-L272

the-rhetorician commented 2 weeks ago

https://github.com/mozilla/multi-account-containers/blob/873ba0ab09bf0ea1adc555e6020a65a4c41c71bb/src/js/background/assignManager.js#L254-L272 Do I take this javascript code and add it to my userCSS/chromeCSS or something? Newbie trying to learn as much as I can, please explain in detail