mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.71k stars 341 forks source link

Pinned tabs are not reopened in same container #2463

Open bomgar opened 1 year ago

bomgar commented 1 year ago

Before submitting a bug report

Step to reproduce

I have a site that is assigned to a container. I open the site without a container pin the tab. Relaunch firefox

Actual behavior

The addon opens a new tab on firefox relaunch and asks me what to do.

Expected behavior

I expect pinned stuff to just be there the same as before.

Additional informations

No response

Provide a copy of Troubleshooting Information page (optional)

No response

dannycolin commented 1 year ago

The addon opens a new tab on firefox relaunch and asks me what to do.

This is the expected behavior. To solve this issue, you have two choices:

a) tick the "Remember my decision" box so it's permanently assigned to a container b) remove the assignment for this website.

bomgar commented 1 year ago

that might be true for normal tabs. It is strange for pinned tabs though. The tab that asks you which container you want is also not pinned anymore. so not really expected.

dannycolin commented 1 year ago

It is strange for pinned tabs though.

Why is it strange. Pinned tabs aren't tied up to the container mechanism and exist on their own. They exist primarily to avoid a tab to be closed.

The tab that asks you which container you want is also not pinned anymore.

If your pinned tabs aren't pinned anymore when you reopen your browser, this is most likely a bug with Firefox itself. You can report it on bugzilla.mozilla.org.

tesaguri commented 3 months ago

This looks like a subset of #1155.

Couldn't it be implemented for the case of pinned tabs without the platform support, because pinned tabs are only opened through the user's explicit actions instead of through e.g. <a target="_blank"> and there are currently no way to directly open a new tab as a pinned Container tab AFAICT, so you can deduce that a pinned Container tab has gone through a Multi-Account Containers Confirm Navigation prompt from a previous session? (I admit the premise is quite fragile though.)

The tab that asks you which container you want is also not pinned anymore.

If your pinned tabs aren't pinned anymore when you reopen your browser, this is most likely a bug with Firefox itself.

I guess that is due to the behavior of #1835 (open a new tab and remove the existing one) instead of a but with Firefox.