search

mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.71k stars 341 forks source link

Swap innerHTML to document.createFragment for pageAction/popup #2491

Closed maxxcrawford closed 1 year ago

maxxcrawford commented 1 year ago

Summary

When submitting to AMO, there's a warning about using innerHTML.

~Blocking L10N PR:~ https://github.com/mozilla-l10n/multi-account-containers-l10n/pull/22

This PR replaces all instances of it.

TODO:

Testing

This should have no visible changes in the UI. Check both the popup panel and the pageAction (in the URL bar). Both should appear/match main.

Screenshots

Confirmed with VPN set that the flag setting works/displays as expected:

image
dannycolin commented 1 year ago

@maxxcrawford What do you think of completely removing pageAction right now? See #2477.

dannycolin commented 1 year ago

New container item is duplicated

  1. Open the popup
  2. Click on Manage Container
  3. Click on Back button
  4. Click again on Manage Container

There's now two "+ New Container" items.

You can assign about:newtab to a container

  1. Open the popup
  2. Click on "Always open this site in..."
  3. Select a container

Tab reopens in the assigned container.

  1. Reopen the popup
  2. Click on Manage Containers
  3. Choose the container you assign about:newtab to
  4. Click on Manage site list

There's an entry without a title corresponding to about:newtab

maxxcrawford commented 1 year ago

Closing right now to stop blocking @dannycolin on other stuff.