Add `file:` protocol to non-permissible protocol list

mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.

https://addons.mozilla.org/firefox/addon/multi-account-containers/

Mozilla Public License 2.0

2.64k stars 322 forks source link

Add `file:` protocol to non-permissible protocol list #2509

Closed drien closed 1 year ago

drien commented 1 year ago

This fixes #2233, see additional notes from my investigation there. Previous unmerged identical PR: https://github.com/mozilla/multi-account-containers/pull/1927.

Here's a screencast of me reproducing the issue, then making this code change and testing the fix: Screencast from 02-16-2023 12:56:06 PM.webm

dannycolin commented 1 year ago

Hey @drien,

Thanks a lot for resurfacing this issue! I guess it fell in a crack when the previous PR got closed. LGTM 🎉.

dannycolin commented 1 year ago

@drien We had a small problem with the GitHub CI. Could you rebase your branch on top of main to re-run the tests please? :)