search

mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.64k stars 322 forks source link

Index of the Containers is not changed after managing containers resulting improper shortcut menu arises. #2519

Closed ghost closed 1 year ago

ghost commented 1 year ago

Before submitting a bug report

Step to reproduce

  1. Let us create 3 container Apple, Mango and Grapes respectively.
  2. Ctrl + Shift + 1 on windows will open Apple, Ctrl + Shift + 2: Mango and so on.
  3. If I change the position of Mango to Apple, then shortcut menus don't change accordingly like Ctrl + Shift + 1 will still open Apple though it is in 2nd position now.

Actual behavior

Probably, Shortcut keys are taking the index of the initial state of containers list and when it is changed by the user, it is not changing accordingly. I have describe this in reproduce section well.

Expected behavior

As described in the reproduce section Ctrl + Shift + 1 on windows should open Mango tab now as user has already changed it's listing position on the container list.

Additional informations

No response

Provide a copy of Troubleshooting Information page (optional)

No response

dannycolin commented 1 year ago

This is the expected behavior. A container uses the shortcut the user assgined to it in the addon settings.

  1. Type about:addons in address bar
  2. Click on Multi-Account Containers in the list
  3. Go to the preferences tab

In the Keyboard Shortcuts, you can assign a container to one of the available shortcut.

jus-jus commented 1 year ago

What is the purpose then allowing user to reorder container list pressing Ctrl+. ? And seeing that container lists do not match anymore? It's confusing and feels like something isn't working properly

dannycolin commented 1 year ago

What is the purpose then allowing user to reorder container list pressing Ctrl+. ? And seeing that container lists do not match anymore? It's confusing and feels like something isn't working properly

When the popup is open, you don't use the addon shortcuts but a quick access shortcut for the first 10 containers in the list. I can see why it can be confusing but I don't know why it was implemented this way. I guess one was added a while after the other one.

It's an interesting UX inconsistency tho. Simply changing the addon shortcuts when the list change could also be confusing since the reordering option isn't at the same place as the shortcuts one. I'm only a volunteer so I'm not the one making the final call on these things but I'd be open to help with the UX aspect and code review if someone wants to provide a patch.