Open Cimbali opened 9 months ago
I was going over the code to look at writing up some PRs and stumbled across 2 small easily corrected issues:
resolve()
getByContainer()
getAssignedSites()
_getByContainer()
I was going over the code to look at writing up some PRs and stumbled across 2 small easily corrected issues:
resolve()
being called twice, which is meaningless.Note that I’ve checked that using else for fallback/function exit is OK per style, see e.g. https://github.com/mozilla/multi-account-containers/blob/60b40a2d9f609572bd55fd59f7206ff4680365ef/src/js/background/assignManager.js#L16-L20
getByContainer()
which doesn’t exist (there is agetAssignedSites()
which in turn calls_getByContainer()
)