mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.64k stars 322 forks source link

Revert monitoring modifier in popup shortcuts #2587

Closed dannycolin closed 7 months ago

dannycolin commented 8 months ago

Description

Fix a regression in our shortcut listener. The previous patch was listening if a modifier was pressed in order to prevent conflicts with Firefox builtin shortcuts. However, the implementation had a side effect of preventing the insertion of characters from a key combination including a modifier.

You can test this fix by trying to insert characters like @ or :. Also, you can test to press shift + 1 to see the behavior I'm considering a conflict with Firefox. The addon popup stays open while the focus is now a newly opened tab.

Note: The conflict with Firefox builtin shortcuts existed prior to both the patch already landed in main and this fix so it doesn't remove any functionality.

Type of change

Select all that apply.