mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.64k stars 323 forks source link

Use `/usr/bin/env` to find bash #2599

Closed abhillman closed 7 months ago

abhillman commented 7 months ago

Before submitting your pull request

Description

This enables npm test to successfully call scripts in bin/ with the bash binary specified by PROFILE.


Additional information:

In addition to potentially preferring an alternative version of bash than the one in /bin/bash, some distributions forego storing bash in bin/ at all, such as NixOS:

$ cat /etc/os-release | rg '^NAME=' -r ''
NixOS
$ which bash
/run/current-system/sw/bin/bash

Type of change

Select all that apply.

Tag issues related to this pull request:

Related pull requests:

dannycolin commented 7 months ago

Definitely agree with the portability argument so LGTM. Thanks for your contribution :).