Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
When you try to open an assigned site in a container to which it is not assigned, or in no container at all, the "confirm-page" shows up:
In this page, the "Remember my decision for this site" checkbox is only useful if you press the blue "Open in {container-name} container" button, but does nothing if you press the gray button.
This PR makes the checkbox useful for when you press the gray button, changing the site's assigned container to the one you were trying to open it in, or removing the site's assignment if you wanted to open the site in a no-container tab and checked the checkbox.
Aside from that, I fixed a bug where a nonexistent method storageArea.getByContainer was called in assignManager.js, once this was breaking my changes (this is apparently also fixed in the #2572 PR).
Type of change
Select all that apply.
[x] Bug fix
[ ] New feature
[ ] Major change (fix or feature that would cause existing functionality to work differently than in the current version)
gravelfreeman
commented
1 week ago
Before submitting your pull request
npm testand all tests passed.Description
When you try to open an assigned site in a container to which it is not assigned, or in no container at all, the "confirm-page" shows up:
In this page, the "Remember my decision for this site" checkbox is only useful if you press the blue "Open in {container-name} container" button, but does nothing if you press the gray button.
This PR makes the checkbox useful for when you press the gray button, changing the site's assigned container to the one you were trying to open it in, or removing the site's assignment if you wanted to open the site in a no-container tab and checked the checkbox.
Aside from that, I fixed a bug where a nonexistent method
storageArea.getByContainerwas called in assignManager.js, once this was breaking my changes (this is apparently also fixed in the #2572 PR).Type of change
Select all that apply.
Tag issues related to this pull request:
2612