mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.75k stars 344 forks source link

Assign bookmark to Container #323

Open gwynnarth opened 7 years ago

gwynnarth commented 7 years ago

~~Currently it is possible to open a link that's on a page into a specific container by right-clicking and choosing appropriate "context" from dropdown menu, but you cannot do that with a bookmark, neither from Bookmark bar nor from Bookmarks menu. It would be useful to be able to right-click a bookmark and open it into a container.~~

Or might be even more useful if user could associate a particular bookmark with a particular Container so that it automatically opens in the right Container. So when I left-click "Facebook" bookmark it opens in "Facebook" container, when I left-click my Online banking website it automatically launches into "Finances" container.

Note: Edited by @dannycolin to make it clearer that opening a bookmark in a container is now resolved but that assigning a bookmark to a container is not.

jonathanKingston commented 7 years ago

There is a platform bug for this as I'm not sure we can add this to the experiment but certainly can add it to the Nightly changes we will be doing: https://bugzilla.mozilla.org/show_bug.cgi?id=1334696

aperkins81 commented 7 years ago

Until I saw this, I was nearly going to create an issue that adding a matching Tag to a bookmark does not auto-container bookmarks. Glad to hear it's being looked at, would be a useful tool.

biva commented 7 years ago

In addition, it would be great that the behavior takes the keyboard shortcuts into consideration, as suggested in https://github.com/mozilla/testpilot-containers/issues/119

klint commented 7 years ago

This is definitely what I miss the most today with containers. With the following default behaviour, IMHO: assuming you have a tab already opened in a certain container, left clicking from that tab on a bookmark that has no default container assigned (assuming that feature exists, of course ;)) should open the bookmark in the same container, either in the same tab or in a new tab, depending on the default setting for new tabs in Firefox pertaining to when new tabs are opened (see Tab Mix Plus settings).

MurzNN commented 7 years ago

@klint Can you describe how to configure open new tab in same container (in Tab Mix Plus settings)? For me all bookmarks opens in new tab with no container, even if current tab have a container. But if I open bookmark in private tab, it opens new tab in private mode too.

klint commented 7 years ago

@MurzNN Yes, that's the same for me. Sorry, my explanations were confusing. I have mentionned Tab Mix Plus just to say that my Firefox is configured to open any link or bookmark in a new tab, that's all. But container-wise, it behaves exactly like you say. Which does not please me :)

MurzNN commented 7 years ago

Seems that Private tab extension can successfully add menuitems into Bookmarks right-click menu, I see "Open in private tab" menu item after installing extension. Maybe you can lookup it's code and try to add menu item "Open bookmark into Container" via same way?

anewuser commented 7 years ago

@MurzNN Private Tab not only has menu items, but lets you add private: before a URL to automatically open it in a private tab. I have dozens of bookmarks with keywords/custom searches set up that way.

MurzNN commented 7 years ago

Seems in this Firefox issue https://bugzilla.mozilla.org/show_bug.cgi?id=1370499 there are good progress with implementing access to Bookmarks menu via Webextensions API.

klint commented 7 years ago

I also see another usage of a opening a bookmark in a given container either by right-click option or by assigning a container to a bookmark, in the use-case of multiple identities for a same service. Using containers to access Google under several accounts/containers, it would be possible to right-click on a generic "drive.google.com" bookmark to open it under the wanted account/container. Or it would be possible to have several bookmarks to the same URL "drive.google.com", each of them assigned to a specific account/container, and a simple left-click on the right bookmark would do the job.

MichaelTunnell commented 7 years ago

Being able to open bookmarks in containers would be wonderful but assigning containers directly to bookmarks would be absolutely amazing and solve a lot of headaches I currently have to deal with. I want to open a single website with multiple sessions which currently is a pain, if I could assign a container to a bookmark then I could accomplish this with so little effort that I would be amazed.

MurzNN commented 7 years ago

@MichaelTunnell For assigning containers directly to bookmarks we can register specific protocols for each container http://kb.mozillazine.org/Register_protocol and here is discussion how to implement new protocol in Firefox extension: https://github.com/Infocatcher/Private_Tab/issues/187

If we implement this, we can create bookmark links like container-5:http://example.com/ or container:work:http://another.example.com/page.html that will opens in specific container. Now this is only idea for implementation, and maybe in separate issue.

MichaelTunnell commented 7 years ago

specific protocols would be a great option and something like container-work:http://another.example.com/page.html sounds like a great solution for this. I think this would be more useful overall to people who want to go this specific. Opening via the context menu would be nice for occasional usage but the ability to have relatively permanent way to open a bookmark in a particular container would be absolutely game changing.

MichaelTunnell commented 7 years ago

yea I'm aware of Firefox doing things that removes key elements of my workflow. I used to be a huge user of Tab Groups and while these Container Tabs are somewhat similar and fundamentally better it lacks a huge benefit that Tab Groups had which was a more seamless UX.

However, I would hope this new approach too bookmarks and container tabs would be built into the addon rather than a 3rd party method as that would make sure it lasts as long as possible.

Overall the switch to webextensions is a good thing but it certainly has a lot of unfortunate addons that will be left in the wake of obsolescence.

biva commented 7 years ago

Any update on this one? Probably related to https://github.com/mozilla/multi-account-containers/issues/914

MurzNN commented 7 years ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1370499

Andy McKay [:andym] |  Comment 14 • 4 months ago Sounds like a good idea and no-one had any real objection in the meeting, so let's do this.

klint commented 7 years ago

Yes, as @MichaelTunnell said (sorry I don't know how to quote here!!): "Opening via the [bookmark] context menu would be nice for occasional usage but the ability to have relatively permanent way to open a bookmark in a particular container would be absolutely game changing."

I really miss this feature, now that I have moved to FF57 totally. And I'm pleased with it.

tradewatcher commented 7 years ago

lol a simple feature request since more than 6 months for an important basic feature. xD

upvote

davidclarke-au commented 7 years ago

Have another vote from me, trying to migrate from Chrome, this is the big one stopping me at the moment.

Thanks

MichaelTunnell commented 7 years ago

@davidclarke-au how can you do this in Chrome?

davidclarke-au commented 7 years ago

@MichaelTunnell in Chrome, I have 2 profiles setup, one with my personal Gmail, and one with my Work GSuite account. This runs in 2 separate instances of Chrome, therefore, any new tab, link etc is always opened within that context.

I also tried about:profiles but couldn't get this to work.

MurzNN commented 7 years ago

Seems feature is successfully implemented in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1370499

Support WebExtensions bookmark context menus RESOLVED FIXED in Firefox 59

MichaelTunnell commented 7 years ago

@davidclarke-au I see. That's kind of what I expected but I do not like the profile structure because I dont want a separate window always. It would still be good to have this separation though.

By the way, Chrome has separate instances for literally every tab and even more for each runtime stuff, not just profiles. That is why it uses up so much RAM when you have lot of tabs.


@MurzNN while that is good . . . context menu is almost not really important to me when compared to assigning containers directly to bookmarks with specific protocols . . . I want that so freaking much.

MurzNN commented 7 years ago

"assigning containers directly to bookmarks" is another feature, that also will be good, but current issue is for menu items. Let's create separate feature request about assigning containers directly to bookmarks?

davidclarke-au commented 7 years ago

@MichaelTunnell spot on and I agree, it's high memory usage was the catalyst for me to see if I could move to Firefox, so far so good, just a few small gotcha's.

MurzNN commented 6 years ago

Mozilla implement function for modify bookmarks menu: https://bugzilla.mozilla.org/show_bug.cgi?id=1370499#c32 - can we add this feature now?

groovecoder commented 6 years ago

Yes, looks like it will be possible in 59. Labeling help wanted and context menu.

klint commented 6 years ago

Hi Is there any update on the 2 requests here? Or are there known addons that fullfil the needs?

sheam commented 6 years ago

This is something I am really missing from Chrome. Chrome allowed you to manage your bookmarks per container which was great.

Subbed, I'll revisit FF when it has a better way to deal with this. Too hard to keep work and personal seperate right now.

mitchp commented 6 years ago

Please. Please. Please. Add "open bookmark in container" to context menu when I right-click a bookmark (where ever it is -- tab bar, etc.). Then, submenu with container list so you can just click a container plus an "add new container" in that sub-context menu.

I have Gmail as a bookmark, but I want to open it in "mystuff" container sometimes or "work" or "some client" (different gmail accounts)... I don't want 10 gmail bookmarks, each assigned to a different container.

MurzNN commented 6 years ago

Ability to modify bookmark context menus are landed in Firefox 59: https://bugzilla.mozilla.org/show_bug.cgi?id=1370499#a14472724_445472 Maybe this feature will be implemented here https://github.com/totallymike/contextPlus/issues/3 in near future.

mitchp commented 6 years ago

Thanks!

On Tue, Jul 3, 2018 at 3:27 AM Alexey Murz Korepov notifications@github.com wrote:

Maybe this feature will be implemented here totallymike/contextPlus#3 https://github.com/totallymike/contextPlus/issues/3 in near future.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mozilla/multi-account-containers/issues/323#issuecomment-402098052, or mute the thread https://github.com/notifications/unsubscribe-auth/ADDSQJsUuhp3J4fMGrWOlBRz88WU-LQLks5uC0cVgaJpZM4MSBQr .

Rob--W commented 6 years ago

I've created an add-on that adds a context menu item to the bookmarks menu that offers the ability to open a bookmark in a container tab. If a bookmark folder is clicked, all links in this folder will be opened in container tabs (i.e. the behavior requested in #1251).

Install from: https://addons.mozilla.org/en-US/firefox/addon/open-bookmark-in-container-tab/ Source code / issue tracker: https://github.com/Rob--W/bookmark-container-tab

K-Langoso commented 6 years ago

Any news on this front?

Thanks!

Millichrome commented 5 years ago

I am currently using Rob--W's extension (Thanks), would love to have this integrated in the containers feature.

xboss182 commented 5 years ago

how to open 1 bookmark in open container simultaneously, not click on open in container 1,2,3,4.. manually?

thelaith commented 5 years ago

Any news?

MichaelTunnell commented 5 years ago

@xboss182 not possible, sadly.

@thelaith not really. I don't expect this to ever happen at this point by the official addon since it has been almost 2 years since requested. Our best bet is for a separate addon to be made but that's not happening yet either. @Rob--W addon is nice but doesn't really accomplish the overall goal.

xboss182 commented 5 years ago

@MichaelTunnell thanks mate

GodKratos commented 5 years ago

I've finally found a work around solution that makes this behaviour work as desired thanks to the post here

Using the Redirector addon I made two rules as follows: Rule 1

Rule 2

image

What this means is that I can add #redirect-containername to the end of any bookmark URL and then configure the URL http://www.containername.myredirect to auto open in the required container and when you click the bookmark it will switch to the redirect site, open in the container, then redirect back to the bookmark URL.

Works a treat and can be used for redirecting to any container you like.

MurzNN commented 5 years ago

@GodKratos, thanks for very good workaround!

caltheon commented 5 years ago

@GodKratos

I follow all of it until the part where you add http://www.containername.myredirect to auto open in the required container. How do you manage that? Since it isn't a real URL, I can't do it the normal way of going to the site and choosing open in this container, it just gets redirected to ISP search page. I may be blind, but I don't see any way to configure the website list explicitly in the container plugin either.

Edit: found a workaround that is a bit clutzy on this post https://github.com/mozilla/multi-account-containers/issues/1227 You disable your internet connection temporarily to stop the annoying ISP domain not found redirect. Hopefully there is a better way.

MichaelTunnell commented 5 years ago

@GodKratos that is a great solution! it is convoluted and has a lot of setup but once it is done it works perfectly so thank you for sharing this solution!

@caltheon ISP redirects are awful. There are a few options though. 1.) disable internet like you did. 2.) change your DNS provider. 3.) use a separate extension (Containerise) to handle that

GodKratos commented 5 years ago

@caltheon I just browsed to the redirect URL in my address bar and it just fails to the load the site but still allows me to add it to the container. Remember to enter in the URL including the http:// part into the address bar and not the search bar. If you don't add the http:// it will try to do a search but it also sounds like your ISP does some search thing for unknown URLs? If I click the link in your post to that redirect URL it opens a page saying "server not found" and I can add that to a container. Does that not happen for you?

rafaelgomesxyz commented 5 years ago

Hi all, I've created an extension that makes the workaround posted by @GodKratos easier / faster to manage. Thanks for the workaround, by the way!

Install here: https://addons.mozilla.org/en-US/firefox/addon/container-bookmarks/ Source code: https://github.com/rafael-gssa/container-bookmarks

Edit: I might have done something wrong in the extension, because it seems to slow down requests (or rather it's intercepting all kinds of requests and therefore using a ton of CPU). Probably something with the way I handled webRequest, I'll see how I can fix that.

Edit: I think I fixed it, I limited it to main frame requests only.

olympus123 commented 5 years ago

I've found this new add-on Open external links in a container This extension enables support for opening links in specific containers using custom protocol handler. It works for terminal, OS shortcuts and regular HTML pages.

https://addons.mozilla.org/en-US/firefox/addon/open-url-in-container/

Amaaaziiing, it works for bookmarks and it even creates the container if it doesn't exist! It doesn't even need Multi-Accounts add-on or Containerise to work...

ext+container:name=MyContainer&color=orange&icon=fruit&url=https://mozilla.org

rafaelgomesxyz commented 5 years ago

Wow, hadn't even thought of protocol handlers, amazing. Only problem for bookmarks is the icons not appearing, but for everything else, specially for opening from the terminal, it's great!

olympus123 commented 5 years ago

Wow, hadn't even thought of protocol handlers, amazing. Only problem for bookmarks is the icons not appearing, but for everything else, specially for opening from the terminal, it's great!

Yes, firefox can't get the favicons. I personally use Humble New Tab Page, which shows my bookmarks in new tab page. I don't use bookmarks toolbar because Firefox sync can't sync favicons and in a new install I would have to open all bookmarks to save their favicons. Humble New Tab Page can get their favicons automatically if I select to get them from faviconkit.com https://addons.mozilla.org/en-US/firefox/addon/humble-new-tab/

rafaelgomesxyz commented 5 years ago

Yes, firefox can't get the favicons. I personally use Humble New Tab Page, which shows my bookmarks in new tab page. I don't use bookmarks toolbar because Firefox sync can't sync favicons and in a new install I would have to open all bookmarks to save their favicons. Humble New Tab Page can get their favicons automatically if I select to get them from faviconkit.com https://addons.mozilla.org/en-US/firefox/addon/humble-new-tab/

Thanks for the suggestion, but it doesn't look good for me. I have a ton of bookmarks, so I remove their names so that I only see icons in my bookmarks bar, seeing them in a column is not practical. I'll just keep using the extension I made for bookmarks and the one you posted for everything else.

MichaelTunnell commented 5 years ago

@olympus123 great find, thank you for sharing! This was the ideal method that @MurzNN and I were talking about 2 years ago as a solution to this issue. I have installed it and tested it and it works beautifully!

It is true that the favicons don't work anymore due to this method but with that being the only downside to using this vs the Redirector method of extra setup time, I think this is a wonderful solution.

I really love the fact this works in a terminal and if you use a container name that doesn't exist it will create the container for you so you could use this as a way to sync containers in future installs. Import your bookmarks and just launch some bookmarks to create the containers. I think this is something I will make a video about. :D