mozilla / multi-account-containers

Firefox Multi-Account Containers lets you keep parts of your online life separated into color-coded tabs that preserve your privacy. Cookies are separated by container, allowing you to use the web with multiple identities or accounts simultaneously.
https://addons.mozilla.org/firefox/addon/multi-account-containers/
Mozilla Public License 2.0
2.72k stars 340 forks source link

inconsistencies of colour and name #772

Open grahamperrin opened 7 years ago

grahamperrin commented 7 years ago

Steps

  1. have just one window, with a contained tab
  2. open a new window
  3. use the containers button to edit the colour of that container

Expected

Actual result

┆Issue is synchronized with this Jira Task

jonathanKingston commented 7 years ago

I also don't see the underline update. Are you using Nightly? What OS are you using?

grahamperrin commented 7 years ago
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% date ; uname -v
Tue 29 Aug 2017 00:05:41 BST
FreeBSD 12.0-CURRENT #0 r320869: Mon Jul 10 13:57:55 UTC 2017     root@releng3.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC 
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% pkg info firefox | grep -i version
Version        : 55.0.3_1,1
[grahamperrin@momh167-gjp4-hpelitebook8570p-freebsd] ~% 

If I disable Vertical Tabs Reloaded then the colour of a container appears as overlines, above its contained tabs. Whilst the colour of elements within the location bar is bugged, overlines are not bugged.

grahamperrin commented 7 years ago

Name, colour and icon of a container changed:

Voilà:

2017-08-29 00 24 40 hinge and bracket

Hinge & Bracket :-)

jonathanKingston commented 7 years ago

@grahamperrin that looks like a Sea containers issue, we just added the API hooks to observe container changes. The icon is missing in 55 as they aren't present in central until 57. I think what I just reproduced is a different issue than what you have.

grahamperrin commented 7 years ago

… icon is missing in 55 as they aren't present in central until 57. …

Thanks for the reminder!

I threw in the Sea Containers aspect for good measure. Ignoring that (to the left):

– it's the same container. Hinge ≠ Bracket and green ≠ pink.

jonathanKingston commented 7 years ago

Yeah ok that looks more like what was working before and what I am seeing. My hunch is we fixed that before in the extension only and then removed it expecting it to work in central.

This will require a platform fix.

grahamperrin commented 7 years ago

Also bugged: single-window environments.

For example, following a change to red:

2017-09-01 03 49 51

2017-09-01 03 50 55