search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

chore: prepare v0.8.2 release #2045

Closed mxinden closed 3 months ago

mxinden commented 3 months ago

Fixes https://github.com/mozilla/neqo/issues/2040.

Depends on https://github.com/mozilla/neqo/pull/2044.

larseggert commented 3 months ago

Do we want to land any other PRs?

mxinden commented 3 months ago

No objections to including other PRs.

That said, given that uplifting into mozilla-central is relatively easy, and given Bug 1911658, I would suggest releasing as is, with the option of doing another release in the next couple of days.

github-actions[bot] commented 3 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.98%. Comparing base (72a42db) to head (2a0929c). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2045 +/- ## ========================================== - Coverage 94.99% 94.98% -0.01% ========================================== Files 112 112 Lines 36415 36415 ========================================== - Hits 34591 34589 -2 - Misses 1824 1826 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larseggert commented 3 months ago

WFM too

github-actions[bot] commented 3 months ago

Benchmark results

Performance differences relative to 72a42dbbf8b059097d52f70048b5bfec9d27c9fb.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [193.56 ns 194.06 ns 194.63 ns]
       change: [-0.8210% -0.4248% +0.0035%] (p = 0.04 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [235.26 ns 235.77 ns 236.33 ns]
       change: [-1.1448% -0.6486% -0.1901%] (p = 0.01 < 0.05)

Found 13 outliers among 100 measurements (13.00%)
  13 (13.00%) high severe
coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [234.81 ns 235.60 ns 236.53 ns]
       change: [-1.4301% -0.9080% -0.2913%] (p = 0.00 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
  1 (1.00%) high mild
  9 (9.00%) high severe
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [214.79 ns 215.04 ns 215.34 ns]
       change: [-1.4632% -0.7624% -0.0384%] (p = 0.03 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
  4 (4.00%) high mild
  5 (5.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [121.26 ms 121.33 ms 121.40 ms]
       change: [-0.3700% -0.1358% +0.0161%] (p = 0.19 > 0.05)

Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [37.750 ms 39.854 ms 41.946 ms]
       change: [-13.125% -6.5542% +0.8254%] (p = 0.08 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [54.568 ms 57.688 ms 60.851 ms]
       change: [-10.626% -3.1569% +4.2283%] (p = 0.42 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [48.105 ms 49.688 ms 51.230 ms]
       change: [-7.0283% -3.1678% +1.1387%] (p = 0.15 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [61.320 ms 68.109 ms 74.811 ms]
       change: [-15.439% -3.6987% +9.5341%] (p = 0.58 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [166.48 ms 171.76 ms 177.97 ms]
       thrpt:  [561.89 MiB/s 582.19 MiB/s 600.66 MiB/s]
change:
       time:   [-4.7370% +0.3247% +5.4476%] (p = 0.90 > 0.05)
       thrpt:  [-5.1662% -0.3236% +4.9726%]

Found 8 outliers among 100 measurements (8.00%)
  2 (2.00%) high mild
  6 (6.00%) high severe
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [409.99 ms 413.48 ms 416.85 ms]
       thrpt:  [23.990 Kelem/s 24.185 Kelem/s 24.391 Kelem/s]
change:
       time:   [-1.7309% -0.5839% +0.5372%] (p = 0.32 > 0.05)
       thrpt:  [-0.5344% +0.5873% +1.7613%]

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [46.202 ms 46.925 ms 47.656 ms]
       thrpt:  [20.984  elem/s 21.310  elem/s 21.644  elem/s]
change:
       time:   [-1.3371% +0.8116% +3.0802%] (p = 0.46 > 0.05)
       thrpt:  [-2.9881% -0.8051% +1.3552%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 169.4 ± 91.0 103.4 403.1 1.00
neqo msquic reno on 296.0 ± 57.3 258.0 453.3 1.00
neqo msquic reno 317.4 ± 87.6 260.3 522.4 1.00
neqo msquic cubic on 286.3 ± 60.5 252.0 456.3 1.00
neqo msquic cubic 309.3 ± 63.4 258.4 455.3 1.00
msquic neqo reno on 616.6 ± 1741.4 124.6 7369.9 1.00
msquic neqo reno 177.4 ± 63.0 125.8 359.0 1.00
msquic neqo cubic on 179.5 ± 57.4 117.4 353.3 1.00
msquic neqo cubic 168.8 ± 35.9 109.8 238.8 1.00
neqo neqo reno on 215.7 ± 72.1 159.2 386.5 1.00
neqo neqo reno 202.6 ± 60.0 162.9 359.6 1.00
neqo neqo cubic on 176.5 ± 28.5 144.2 268.3 1.00
neqo neqo cubic 203.5 ± 76.9 145.5 410.1 1.00

:arrow_down: Download logs

github-actions[bot] commented 3 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.