search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

ci: Allow `binstall` to handle current Rust install issue #2048

Closed larseggert closed 3 months ago

github-actions[bot] commented 3 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.36%. Comparing base (ca0080e) to head (3b288e0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2048 +/- ## ======================================= Coverage 95.36% 95.36% ======================================= Files 112 112 Lines 36463 36463 ======================================= Hits 34772 34772 Misses 1691 1691 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Benchmark results

Performance differences relative to ca0080e41ec3b06f1813da1c774ca321231e7eec.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [192.54 ns 192.99 ns 193.51 ns]
       change: [-1.7765% -1.0196% -0.4498%] (p = 0.00 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
  6 (6.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [235.09 ns 235.57 ns 236.11 ns]
       change: [-0.5440% +0.3064% +2.0022%] (p = 0.74 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
  1 (1.00%) low mild
  12 (12.00%) high severe
coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [235.09 ns 235.48 ns 235.98 ns]
       change: [-0.9016% -0.4606% -0.0311%] (p = 0.04 < 0.05)

Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) low mild
  2 (2.00%) high mild
  3 (3.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [216.42 ns 216.72 ns 217.07 ns]
       change: [-0.5440% +0.1000% +0.8025%] (p = 0.77 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe
RxStreamOrderer::inbound_frame(): :green_heart: Performance has improved.
       time:   [118.40 ms 118.47 ms 118.55 ms]
       change: [-2.5121% -2.4384% -2.3624%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [39.516 ms 41.274 ms 43.087 ms]
       change: [-7.9323% -1.4067% +5.2635%] (p = 0.68 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
  1 (1.00%) low mild
  4 (4.00%) high mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [56.487 ms 59.645 ms 62.811 ms]
       change: [-5.6126% +1.8305% +10.016%] (p = 0.64 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [47.684 ms 49.292 ms 50.867 ms]
       change: [-6.1037% -1.4317% +3.1593%] (p = 0.54 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [70.762 ms 77.043 ms 83.267 ms]
       change: [-7.0260% +3.7505% +17.144%] (p = 0.54 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
  6 (6.00%) low mild
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [169.92 ms 175.19 ms 182.83 ms]
       thrpt:  [546.96 MiB/s 570.80 MiB/s 588.50 MiB/s]
change:
       time:   [-2.3588% +1.0848% +5.6805%] (p = 0.65 > 0.05)
       thrpt:  [-5.3752% -1.0731% +2.4158%]

Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high severe
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold.
       time:   [410.24 ms 413.95 ms 417.59 ms]
       thrpt:  [23.947 Kelem/s 24.157 Kelem/s 24.376 Kelem/s]
change:
       time:   [+0.1788% +1.3911% +2.5889%] (p = 0.03 < 0.05)
       thrpt:  [-2.5236% -1.3721% -0.1785%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold.
       time:   [45.080 ms 45.785 ms 46.488 ms]
       thrpt:  [21.511  elem/s 21.841  elem/s 22.183  elem/s]
change:
       time:   [-4.7095% -2.6185% -0.4357%] (p = 0.02 < 0.05)
       thrpt:  [+0.4376% +2.6889% +4.9423%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 217.8 ± 107.8 102.8 441.4 1.00
neqo msquic reno on 295.5 ± 70.8 261.5 495.4 1.00
neqo msquic reno 267.7 ± 13.9 250.1 300.8 1.00
neqo msquic cubic on 293.5 ± 50.8 254.9 421.5 1.00
neqo msquic cubic 292.8 ± 65.6 252.5 459.9 1.00
msquic neqo reno on 199.9 ± 67.0 117.5 332.0 1.00
msquic neqo reno 211.3 ± 84.3 117.4 355.9 1.00
msquic neqo cubic on 269.3 ± 138.7 165.2 569.9 1.00
msquic neqo cubic 243.4 ± 90.0 134.7 391.1 1.00
neqo neqo reno on 219.6 ± 108.7 141.1 540.9 1.00
neqo neqo reno 249.3 ± 126.9 133.2 576.8 1.00
neqo neqo cubic on 255.0 ± 107.5 145.2 443.8 1.00
neqo neqo cubic 204.8 ± 88.2 139.7 501.1 1.00

:arrow_down: Download logs

github-actions[bot] commented 3 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.