search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

build(deps): bump actions/upload-artifact from 4.3.5 to 4.3.6 #2051

Closed dependabot[bot] closed 3 months ago

dependabot[bot] commented 3 months ago

Bumps actions/upload-artifact from 4.3.5 to 4.3.6.

Release notes

Sourced from actions/upload-artifact's releases.

v4.3.6

What's Changed

Full Changelog: https://github.com/actions/upload-artifact/compare/v4...v4.3.6

Commits


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
github-actions[bot] commented 3 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.36%. Comparing base (f801c29) to head (f4dfb56).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2051 +/- ## ========================================== - Coverage 95.36% 95.36% -0.01% ========================================== Files 112 112 Lines 36475 36475 ========================================== - Hits 34784 34783 -1 - Misses 1691 1692 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 months ago

Benchmark results

Performance differences relative to f801c295df38b3aebe0b481ed5702218663b4308.

coalesce_acked_from_zero 1+1 entries: :broken_heart: Performance has regressed.
       time:   [196.06 ns 196.51 ns 196.99 ns]
       change: [+1.3141% +1.6415% +1.9658%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
  10 (10.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [238.11 ns 238.67 ns 239.25 ns]
       change: [+0.4589% +0.8026% +1.1811%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
  7 (7.00%) high mild
  8 (8.00%) high severe
coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [237.85 ns 238.80 ns 239.90 ns]
       change: [+0.0540% +0.6528% +1.2803%] (p = 0.04 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
  10 (10.00%) high severe
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [217.24 ns 217.45 ns 217.69 ns]
       change: [+0.6055% +1.4248% +2.2359%] (p = 0.00 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
  3 (3.00%) high mild
  7 (7.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [119.14 ms 119.23 ms 119.32 ms]
       change: [+0.4212% +0.5250% +0.6302%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [41.939 ms 43.684 ms 45.433 ms]
       change: [-2.1955% +3.5217% +9.7355%] (p = 0.25 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [54.685 ms 57.569 ms 60.512 ms]
       change: [-3.3449% +4.2343% +12.433%] (p = 0.27 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [47.747 ms 49.254 ms 50.716 ms]
       change: [-6.8084% -2.5194% +1.8264%] (p = 0.28 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [68.602 ms 74.908 ms 81.090 ms]
       change: [-9.1245% +3.4142% +17.151%] (p = 0.60 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [169.15 ms 171.18 ms 173.30 ms]
       thrpt:  [577.05 MiB/s 584.18 MiB/s 591.18 MiB/s]
change:
       time:   [-2.8354% -1.2097% +0.4193%] (p = 0.15 > 0.05)
       thrpt:  [-0.4175% +1.2246% +2.9181%]

Found 3 outliers among 100 measurements (3.00%)
  3 (3.00%) high mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [405.52 ms 409.31 ms 413.12 ms]
       thrpt:  [24.206 Kelem/s 24.431 Kelem/s 24.659 Kelem/s]
change:
       time:   [-1.5314% -0.2960% +0.9798%] (p = 0.65 > 0.05)
       thrpt:  [-0.9703% +0.2969% +1.5552%]

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [46.124 ms 46.892 ms 47.660 ms]
       thrpt:  [20.982  elem/s 21.326  elem/s 21.680  elem/s]
change:
       time:   [-2.7081% -0.4213% +1.9200%] (p = 0.72 > 0.05)
       thrpt:  [-1.8838% +0.4231% +2.7835%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 132.8 ± 48.9 101.8 317.3 1.00
neqo msquic reno on 279.0 ± 11.9 258.6 296.3 1.00
neqo msquic reno 264.5 ± 9.9 248.4 280.3 1.00
neqo msquic cubic on 260.1 ± 7.7 248.3 276.6 1.00
neqo msquic cubic 266.5 ± 9.8 252.5 280.3 1.00
msquic neqo reno on 135.8 ± 20.5 102.8 159.7 1.00
msquic neqo reno 137.4 ± 17.9 110.5 160.3 1.00
msquic neqo cubic on 178.2 ± 17.6 129.1 201.5 1.00
msquic neqo cubic 169.2 ± 34.3 110.7 213.0 1.00
neqo neqo reno on 170.2 ± 13.0 158.4 201.6 1.00
neqo neqo reno 165.1 ± 17.2 138.5 220.1 1.00
neqo neqo cubic on 172.9 ± 16.6 142.4 201.9 1.00
neqo neqo cubic 171.9 ± 9.0 158.3 189.9 1.00

:arrow_down: Download logs

github-actions[bot] commented 3 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.