search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.83k stars 123 forks source link

Add a tiny bit of hygiene to this macro #2060

Closed martinthomson closed 1 month ago

github-actions[bot] commented 1 month ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (abcd70f) to head (636996e). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2060 +/- ## ======================================= Coverage 95.35% 95.35% ======================================= Files 112 112 Lines 36499 36499 ======================================= Hits 34804 34804 Misses 1695 1695 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Benchmark results

Performance differences relative to abcd70f92162db34fc01be9e1c2508ef479a46f3.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [99.635 ns 99.925 ns 100.24 ns]
       change: [-0.9354% -0.4970% -0.0294%] (p = 0.03 < 0.05)

Found 10 outliers among 100 measurements (10.00%)
  5 (5.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [117.78 ns 118.12 ns 118.50 ns]
       change: [-1.1725% -0.6552% -0.0025%] (p = 0.03 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
  2 (2.00%) low severe
  1 (1.00%) high mild
  12 (12.00%) high severe
coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [117.34 ns 117.76 ns 118.28 ns]
       change: [-1.0485% -0.6502% -0.2905%] (p = 0.00 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
  3 (3.00%) low severe
  3 (3.00%) low mild
  4 (4.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [97.258 ns 97.359 ns 97.482 ns]
       change: [-2.2847% -1.4820% -0.5587%] (p = 0.00 < 0.05)

Found 12 outliers among 100 measurements (12.00%)
  4 (4.00%) high mild
  8 (8.00%) high severe
RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [111.14 ms 111.19 ms 111.24 ms]
       change: [-0.2791% -0.2139% -0.1456%] (p = 0.00 < 0.05)

Found 4 outliers among 100 measurements (4.00%)
  4 (4.00%) high mild
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.867 ms 27.789 ms 28.702 ms]
       change: [-5.5769% -0.7905% +4.2499%] (p = 0.75 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) low mild
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.992 ms 36.855 ms 38.735 ms]
       change: [-6.1020% +0.6264% +8.2807%] (p = 0.86 > 0.05)
transfer/pacing-false/same-seed: :green_heart: Performance has improved.
       time:   [31.218 ms 31.924 ms 32.608 ms]
       change: [-9.0676% -6.1228% -3.1087%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) low mild
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [40.963 ms 44.068 ms 47.192 ms]
       change: [-14.505% -5.5315% +4.3550%] (p = 0.27 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [115.31 ms 116.16 ms 117.45 ms]
       thrpt:  [851.43 MiB/s 860.91 MiB/s 867.24 MiB/s]
change:
       time:   [-0.6275% +0.3870% +1.5896%] (p = 0.54 > 0.05)
       thrpt:  [-1.5647% -0.3855% +0.6315%]

Found 2 outliers among 100 measurements (2.00%)
  1 (1.00%) low mild
  1 (1.00%) high severe
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [306.53 ms 310.28 ms 314.05 ms]
       thrpt:  [31.842 Kelem/s 32.229 Kelem/s 32.623 Kelem/s]
change:
       time:   [-1.9521% -0.3943% +1.1853%] (p = 0.63 > 0.05)
       thrpt:  [-1.1715% +0.3959% +1.9910%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [40.359 ms 41.064 ms 41.772 ms]
       thrpt:  [23.940  elem/s 24.352  elem/s 24.778  elem/s]
change:
       time:   [-2.1387% +0.1693% +2.5983%] (p = 0.89 > 0.05)
       thrpt:  [-2.5325% -0.1690% +2.1855%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 112.2 ± 35.6 82.8 191.7 1.00
neqo msquic reno on 221.3 ± 15.4 205.3 249.9 1.00
neqo msquic reno 216.9 ± 12.3 205.6 240.8 1.00
neqo msquic cubic on 228.1 ± 13.8 207.1 255.3 1.00
neqo msquic cubic 214.5 ± 10.8 205.2 235.6 1.00
msquic neqo reno on 82.7 ± 17.5 73.2 163.5 1.00
msquic neqo reno 87.7 ± 20.2 73.9 168.1 1.00
msquic neqo cubic on 82.7 ± 12.5 73.6 130.4 1.00
msquic neqo cubic 84.4 ± 14.8 73.8 134.8 1.00
neqo neqo reno on 166.6 ± 58.4 122.2 345.2 1.00
neqo neqo reno 145.1 ± 23.9 122.2 221.5 1.00
neqo neqo cubic on 172.2 ± 66.4 124.4 340.8 1.00
neqo neqo cubic 161.8 ± 65.0 121.9 400.9 1.00

:arrow_down: Download logs

github-actions[bot] commented 1 month ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.