search

mozilla / neqo

Neqo, the Mozilla Firefox implementation of QUIC in Rust
https://firefox-source-docs.mozilla.org/networking/http/http3.html
Apache License 2.0
1.85k stars 124 forks source link

fix: Reduce log level for QNS `transfer` and `blackhole` #2070

Closed larseggert closed 2 months ago

larseggert commented 2 months ago

These are just way too noisy otherwise, making artifact download slow.

github-actions[bot] commented 2 months ago

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.35%. Comparing base (43ce605) to head (ea1fa33). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2070 +/- ## ======================================= Coverage 95.35% 95.35% ======================================= Files 112 112 Lines 36505 36505 ======================================= Hits 34811 34811 Misses 1694 1694 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

larseggert commented 2 months ago

Closed in favor of #2071.

github-actions[bot] commented 2 months ago

Benchmark results

Performance differences relative to adf4722206926903f951c9e313b23980cd2b4d02.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.765 ns 99.091 ns 99.421 ns]
       change: [-0.1725% +0.2498% +0.6968%] (p = 0.27 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
  9 (9.00%) high mild
  5 (5.00%) high severe
coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [117.35 ns 117.73 ns 118.13 ns]
       change: [-0.5674% +0.1284% +0.9029%] (p = 0.78 > 0.05)

Found 19 outliers among 100 measurements (19.00%)
  2 (2.00%) low severe
  2 (2.00%) low mild
  2 (2.00%) high mild
  13 (13.00%) high severe
coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.09 ns 117.62 ns 118.25 ns]
       change: [-0.6049% -0.0125% +0.5296%] (p = 0.96 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
  5 (5.00%) low severe
  2 (2.00%) low mild
  11 (11.00%) high severe
coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [96.759 ns 96.903 ns 97.065 ns]
       change: [-1.4139% -0.3882% +0.5948%] (p = 0.47 > 0.05)

Found 7 outliers among 100 measurements (7.00%)
  2 (2.00%) high mild
  5 (5.00%) high severe
RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [111.50 ms 111.63 ms 111.83 ms]
       change: [-0.2444% -0.0007% +0.2271%] (p = 1.00 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
  2 (2.00%) low mild
  3 (3.00%) high mild
  1 (1.00%) high severe
transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [27.439 ms 28.342 ms 29.239 ms]
       change: [-3.4961% +1.2255% +6.2350%] (p = 0.62 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.529 ms 37.417 ms 39.325 ms]
       change: [-3.7358% +3.3333% +11.160%] (p = 0.38 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
  1 (1.00%) high mild
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [30.916 ms 31.626 ms 32.330 ms]
       change: [-5.9547% -2.9498% +0.2172%] (p = 0.07 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected.
       time:   [42.685 ms 45.626 ms 48.521 ms]
       change: [-14.652% -6.9764% +1.1245%] (p = 0.10 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [114.38 ms 114.79 ms 115.18 ms]
       thrpt:  [868.19 MiB/s 871.17 MiB/s 874.27 MiB/s]
change:
       time:   [-0.6667% +0.1548% +0.8612%] (p = 0.71 > 0.05)
       thrpt:  [-0.8539% -0.1545% +0.6712%]

Found 3 outliers among 100 measurements (3.00%)
  1 (1.00%) low severe
  2 (2.00%) low mild
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [310.08 ms 313.76 ms 317.49 ms]
       thrpt:  [31.497 Kelem/s 31.872 Kelem/s 32.250 Kelem/s]
change:
       time:   [-2.2595% -0.5927% +1.1189%] (p = 0.50 > 0.05)
       thrpt:  [-1.1065% +0.5962% +2.3117%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [40.261 ms 40.952 ms 41.652 ms]
       thrpt:  [24.008  elem/s 24.419  elem/s 24.838  elem/s]
change:
       time:   [-1.7133% +0.6732% +3.2182%] (p = 0.59 > 0.05)
       thrpt:  [-3.1179% -0.6687% +1.7432%]

Client/server transfer results

Transfer of 33554432 bytes over loopback. Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 165.5 ± 90.1 85.9 322.5 1.00
neqo msquic reno on 279.2 ± 84.6 218.1 425.7 1.00
neqo msquic reno 290.4 ± 81.9 217.9 417.8 1.00
neqo msquic cubic on 219.9 ± 14.8 204.6 243.8 1.00
neqo msquic cubic 281.4 ± 134.4 203.5 646.6 1.00
msquic neqo reno on 106.5 ± 55.3 73.3 316.7 1.00
msquic neqo reno 137.0 ± 87.9 74.7 368.8 1.00
msquic neqo cubic on 153.7 ± 99.1 86.2 394.2 1.00
msquic neqo cubic 151.1 ± 86.5 79.8 329.5 1.00
neqo neqo reno on 180.1 ± 82.3 126.4 363.8 1.00
neqo neqo reno 193.5 ± 92.2 122.5 410.7 1.00
neqo neqo cubic on 302.7 ± 170.8 134.3 627.7 1.00
neqo neqo cubic 209.6 ± 75.7 133.3 413.2 1.00

:arrow_down: Download logs

github-actions[bot] commented 2 months ago

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.